#378 fix build with PIC defined (name clash)


There is a simple naming conflict when -DPIC is in the CFLAGS, breaking build of pic.cpp, since there is a local class with name PIC.

Of course I prompty see respectable programmable interrupt controllers complain that they existed before this position-independent code fad, but I still hope they'll understand that they have to give way in the symbol name space here ...

I remember PIC being dodgy on 32 bit x86 before (register starvation during build), but with current gcc, it works. Anyhow, I think it is a good idea to avoid this conflict and propose the attached patch. Of course, I'm fine with any re-name that doesn't conflict, I just chuckled a bit and turned PIC into EPIC.

(I selected group 0.72, as that suffered from the same issue, as I recall, but I'm on 0.74.)


  • Thomas Orgis

    Thomas Orgis - 2012-05-19

    patch fo fix naming conflict with -DPIC (dosbox 0.74)

  • Peter Veenstra

    Peter Veenstra - 2012-05-20

    While I do believe that our PIC is pretty EPIC, I decided for some modesty and opted for the name
    PIC_8529A instead.



Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

No, thanks