Elimination of datatypes library reopening in play.module failed because of DataTypesBase redefinition in play.h header file. The problem is fixed in revision 885. Library base redefinitions occurred throughout the original SASC code and some redefinitions still exist. It might be a good idea to check for additional occurances of library base names when unnecessary library reopenings are eliminated in the future.
Thanks for fixing this. I originally planned to get rid of some of these libbase redefinitions too, but I never got around to actually do it. I'll check out the rest of the modules, and make them to use the global libbase where possible. It shouldn't be a problem with self-contained modules, where the private data structs can't possibly be accessed by other SAS/C modules.
I already fixed the same issue in show.module too. I think the "redefinition" of library bases is necessary in some places in the program or library for 68k binaries to work, but global libbase should be fine for the modules.
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.