Re: [Docutils-develop] Directives branch

[David G. <go...@py...>]

[Felix Wiemann]
> Things that are currently bothering me:
>
> * BaseTopic, the base class for Topic and Sidebar.  We might need a
>   better name, or maybe those two shouldn't have a common base
>   class.

Since they have so much common code, a common base class is called
for.  Call it BasePseudoSection perhaps?

>   "GenericAdmonition" as a base class for all admonitions isn't such
>   a great name either.

BaseAdmonition works well here.

> * Still a lot of duplicate code.
>
>   I wonder if we should merge back first and refactor then (in order
>   to avoid branch divergence), or refactor first and then merge
>   back, in order to be able to spot and fix interface issues before
>   we're in the trunk.

I think it's better to refactor first then merge.

Your branch divergence worries are unfounded, I think.  Have we ever
had a problem before?

>   (I'm especially not sure about the option_spec interface.)

What's your concern?

--=20
David Goodger <http://python.net/~goodger>