From: Felix W. <Fel...@gm...> - 2004-10-21 01:38:21
|
David Goodger wrote: > RCS file: /cvsroot/docutils/docutils/tools/stylesheets/default.css,v > > .first { > - margin-top: 0 } > + margin-top: 0 ! important } > > .last { > - margin-bottom: 0 } > + margin-bottom: 0 ! important } Why "! important"? I'd like to set the top and bottom margins of ``li`` to 0, in order to get nicer rendering e.g. in Opera:: ------------------------------------------------------------------------ Index: default.css =================================================================== RCS file: /cvsroot/docutils/docutils/tools/stylesheets/default.css,v retrieving revision 1.38 diff -u -r1.38 default.css --- default.css 5 Oct 2004 01:22:09 -0000 1.38 +++ default.css 21 Oct 2004 01:34:55 -0000 @@ -243,3 +243,8 @@ ul.auto-toc { list-style-type: none } + +li { + margin-top: 0 ; + margin-bottom: 0 ; + } ------------------------------------------------------------------------ Are there any objections? (Looking at the test files, the rendering seems to be OK in Firefox and Opera.) Should I add "! important" too (because I'm setting top and bottom margins)? -- When replying to my email address, please ensure that the mail header contains 'Felix Wiemann'. http://www.ososo.de/ |
From: David G. <go...@py...> - 2004-10-21 14:17:53
Attachments:
signature.asc
|
[Felix Wiemann] > David Goodger wrote: >> RCS file: /cvsroot/docutils/docutils/tools/stylesheets/default.css,v >> >> .first { >> - margin-top: 0 } >> + margin-top: 0 ! important } >> >> .last { >> - margin-bottom: 0 } >> + margin-bottom: 0 ! important } > > Why "! important"? To override other ``margin-top`` and ``margin-bottom`` styles that are later in the stylesheet or more specific. See <http://www.w3.org/TR/CSS1#the-cascade>. > I'd like to set the top and bottom margins of ``li`` to 0, in order > to get nicer rendering e.g. in Opera:: What's wrong with the existing rendering in Opera? (Why add that style at all? What is the intent?) > Are there any objections? (Looking at the test files, the rendering > seems to be OK in Firefox and Opera.) Did you try IE? Safari? Konqueror? Looks OK to me in Firefox -- makes no difference. > Should I add "! important" too (because I'm setting top and bottom > margins)? No, not without a reason to override style weights/priorities. -- David Goodger <http://python.net/~goodger> |
From: David G. <go...@py...> - 2004-10-21 23:59:26
Attachments:
signature.asc
|
[Felix Wiemann] > But, while checking with the new Opera, I noticed another problem: > Footnotes wrap as if the container was slightly too small. I.e., > the last word wraps to the next line. I made screenshots: > > <http://www.ososo.de/misc/docutils/opera-footnotes.png> > <http://www.ososo.de/misc/docutils/opera-target-fn.png> That looks like a bug in Opera. > The solution is to remove the "padding" entry in default.css. ... > There was no padding anyway, despite the "padding-left: 0.5ex". I > see no visual effect in Opera and Firefox, except that Opera doesn't > do the weird wrapping anymore. With the change, there was a slight difference evident in Safari and IE/Mac (a bit more horizontal space between the left border and the footnote marker), but not significant. If it makes Opera happy, so be it. I checked in the change. [David Goodger] >> Did you try IE? Safari? Konqueror? I was just pointing out that we have to check a good cross-section of browsers before making certain changes. And yes, I can check Safari as well as IE on Mac OS X. -- David Goodger <http://python.net/~goodger> |
From: Felix W. <Fel...@gm...> - 2004-10-21 02:26:33
|
Felix Wiemann wrote: > Are there any objections? (Looking at the test files, the rendering > seems to be OK in Firefox and Opera.) > > Should I add "! important" too (because I'm setting top and bottom > margins)? Same questions for recent checkin: + +div.compound .compound-first, div.compound .compound-middle { + margin-bottom: 0.5em } + +div.compound .compound-last, div.compound .compound-middle { + margin-top: 0.5em } -- When replying to my email address, please ensure that the mail header contains 'Felix Wiemann'. http://www.ososo.de/ |
From: Felix W. <Fel...@gm...> - 2004-10-21 19:59:28
|
David Goodger wrote: > Felix Wiemann wrote: > >> Why "! important"? > > To override other ``margin-top`` and ``margin-bottom`` styles that are > later in the stylesheet or more specific. Hmmm. Obviously. 8-) Now I see. >> I'd like to set the top and bottom margins of ``li`` to 0, in order >> to get nicer rendering e.g. in Opera:: > > What's wrong with the existing rendering in Opera? The rendering of lists in Opera has too much vertical space, but I just found out that it only occurs in Opera 6, not Opera 7. So it's not worth bloating the stylesheet. But, while checking with the new Opera, I noticed another problem: Footnotes wrap as if the container was slightly too small. I.e., the last word wraps to the next line. I made screenshots: <http://www.ososo.de/misc/docutils/opera-footnotes.png> <http://www.ososo.de/misc/docutils/opera-target-fn.png> The solution is to remove the "padding" entry in default.css. ------------------------------------------------------------------------ Index: default.css =================================================================== RCS file: /cvsroot/docutils/docutils/tools/stylesheets/default.css,v retrieving revision 1.41 diff -u -r1.41 default.css --- default.css 21 Oct 2004 14:14:36 -0000 1.41 +++ default.css 21 Oct 2004 19:53:01 -0000 @@ -224,15 +224,13 @@ margin-bottom: 0.5em } table.citation { - border-left: solid thin gray ; - padding-left: 0.5ex } + border-left: solid thin gray } table.docinfo { margin: 2em 4em } table.footnote { - border-left: solid thin black ; - padding-left: 0.5ex } + border-left: solid thin black } td, th { padding-left: 0.5em ; ------------------------------------------------------------------------ There was no padding anyway, despite the "padding-left: 0.5ex". I see no visual effect in Opera and Firefox, except that Opera doesn't do the weird wrapping anymore. > Did you try IE? I just checked the functional test output with IE 5.0 (without the patch above applied though). Looks fine. > Safari? No, I can't, at least not easily. Don't you have a Safari? If yes, it would be nice if you could have a look at the functional test output. > Konqueror? I don't want to install this one. Too big. (I'd have to download 60 MB of useless KDE-bloat over ISDN.) Maybe I can get access to a computer with an installed Konqueror later. -- When replying to my email address, please ensure that the mail header contains 'Felix Wiemann'. http://www.ososo.de/ |