SourceForge has been redesigned. Learn more.
Close

#131 docutils sometimes contains roman

closed-fixed
nobody
None
3
2011-12-20
2010-03-17
No

Docutils includes roman, depending on the install-time environment. This raises problems with setups that use egg-caches (e.g. zc.buildout). I think an egg should always provide the same content, independent of the install-time environment.

roman is available as an egg via pypi (currently 1.4.0) and differs to the one in docutils only in:
--- docutils-0.6-py2.6.egg/roman.py 2010-03-17 09:30:33.029213944 +0100
+++ roman.py 2009-07-23 18:34:18.000000000 +0200
@@ -41,7 +41,7 @@
"""convert integer to Roman numeral"""
if not (0 < n < 5000):
raise OutOfRangeError, "number out of range (must be 1..4999)"
- if int(n) != n:
+ if int(n) <> n:
raise NotIntegerError, "decimals can not be converted"

result = ""

I think docutils should never include roman but require it as a dependency.

Discussion

  • Günter Milde

    Günter Milde - 2010-03-24

    Docutils' source always includes a copy of roman.py. Handling with
    `setup.py install` depends on whether 'roman' already is available
    as a Python module at the target system.

    Distutils allows specifying a dependency since version 2.5
    (http://docs.python.org/release/2.5/whatsnew/pep-314.html) while Docutils
    supports >= 2.3. Hence we have to postpone this solution.

    A patch that implements "don't put roman.py into binaries" but keeps the
    "install if required" could be considered.

     
  • Günter Milde

    Günter Milde - 2010-03-24
    • priority: 5 --> 3
    • status: open --> pending-postponed
     
  • SourceForge Robot

    • status: pending-postponed --> closed-postponed
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • Günter Milde

    Günter Milde - 2011-12-20
    • status: closed-postponed --> closed-fixed
     

Log in to post a comment.