#115 Test suite failure on Windows (CR/LF incompatibility)

closed-works-for-me
nobody
None
5
2009-10-03
2009-06-21
No

20 tests fail.

The functional tests seem to fail due to different line endings or unmatched number of trailing spaces, see attached file.

Used software:
Docutils 0.6 [snapshot 2009-06-21, r5994]
Python 2.6.1
Windows 7 RC 64-bit (6.1.7100)

Discussion

  • Alfred Theorin

    Alfred Theorin - 2009-06-21

    Test output

     
  • Günter Milde

    Günter Milde - 2009-09-03
    • summary: Test suite failure --> Test suite failure on Windows
     
  • Günter Milde

    Günter Milde - 2009-09-03

    Could you please specify which tests fail
    (or even better, if the problem is still manifest in the latest SVN)?

     
  • Alfred Theorin

    Alfred Theorin - 2009-09-04

    I re-ran the tests on the latest snapshot (2009-09-04, r6116) with Python 2.6.1 (r261:67517) and Python 2.6.2 (r262:71605, Apr 14 2009, 22:46:50) [MSC v.1500 64 bit (AMD64)] on win32 and there were now 35 tests which fail.

    All the functions tests fail due to different file endings. The expected output contains windows style line endings (CRLF) while the output contains unix style line endings (LF).

     
  • Günter Milde

    Günter Milde - 2009-09-10
    • summary: Test suite failure on Windows --> Test suite failure on Windows (CR/LF incompatibility)
     
  • Günter Milde

    Günter Milde - 2009-09-10

    It seems your Python (or Docutils) installation is configured to replace a '\n' with LF while it should be
    CRLF on Windows.

    Do you get Unix line endings (LF) also with "real" rst2... runs?
    Do you get Unix line endings with other Python programs that write to a file?

     
  • Alfred Theorin

    Alfred Theorin - 2009-09-10

    A real run of rst2html also outputted only LF.
    Other python programs write CRLF. (Tried with a simple fh.write("\n") program)

    I couldn't find any configuration files for docutils, where should I look?

     
  • Günter Milde

    Günter Milde - 2009-09-11

    OK. I see that in io.py FileOutput opens files in binary mode ('wb' instead of 'w').
    As there is a BinaryFileOutput class too, I suppose this is a side-effect of the latest Python-3 compatibility change.
    Reverting should fix the problem (done in SVN).

     
  • Günter Milde

    Günter Milde - 2009-09-11
    • status: open --> open-fixed
     
  • Alfred Theorin

    Alfred Theorin - 2009-09-11

    I ran the tests again with the latest SVN version (6126) and there are still newline discrepancies, but now it's instead some places with CRCRLF in the output.

     
  • Günter Milde

    Günter Milde - 2009-09-17

    Could you please be more specific or provide sample output? I have no chance to test this due to lack of a Windows system.

     
  • Günter Milde

    Günter Milde - 2009-09-17
    • status: open-fixed --> open-works-for-me
     
  • Alfred Theorin

    Alfred Theorin - 2009-09-17

    I did that already, see attached file "compact_lists_diff.zip". :o)

    All the tests in functional/ have similar discrepancies.

     
  • Günter Milde

    Günter Milde - 2009-09-18
    • status: open-works-for-me --> pending-works-for-me
     
  • SourceForge Robot

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • SourceForge Robot

    • status: pending-works-for-me --> closed-works-for-me
     

Log in to post a comment.