Menu
▾
▴
[ docbook-Patches-1048856 ] Write HH Index and Contents as HTML Files
|
From: SourceForge.net <no...@so...> - 2005-07-30 17:13:53
|
Patches item #1048856, was opened at 2004-10-17 23:02 Message generated for change (Comment added) made by kosek You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373749&aid=1048856&group_id=21935 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: DocBook XSL Group: HTML Help/Java Help/Eclipse He Status: Open Resolution: None Priority: 5 Submitted By: anatoly techtonik (techtonik) Assigned to: Jirka Kosek (kosek) Summary: Write HH Index and Contents as HTML Files Initial Comment: .hhc and .hhk files used for contents and index in HtmlHelp are actually HTML files and should be written accordingly to ease customization. --- docbook-xsl-1.66.1\htmlhelp\htmlhelp-common.xsl Mon Aug 30 09:31:28 2004 +++ docbook-xsl-1.66.1\htmlhelp\htmlhelp-common_.xsl Sun Oct 17 23:53:22 2004 @@ -467,14 +467,14 @@ stuff instead. --> <xsl:template name="hhc"> - <xsl:call-template name="write.text.chunk"> + <xsl:call-template name="write.chunk"> <xsl:with-param name="filename"> <xsl:if test="$manifest.in.base.dir != 0"> <xsl:value-of select="$base.dir"/> </xsl:if> <xsl:value-of select="$htmlhelp.hhc"/> </xsl:with-param> - <xsl:with-param name="method" select="'text'"/> + <xsl:with-param name="indent" select="'yes'"/> <xsl:with-param name="content"> <xsl:call-template name="hhc-main"/> </xsl:with-param> @@ -928,14 +928,14 @@ <!-- ==================================================================== --> <xsl:template name="hhk"> - <xsl:call-template name="write.text.chunk"> + <xsl:call-template name="write.chunk"> <xsl:with-param name="filename"> <xsl:if test="$manifest.in.base.dir != 0"> <xsl:value-of select="$base.dir"/> </xsl:if> <xsl:value-of select="$htmlhelp.hhk"/> </xsl:with-param> - <xsl:with-param name="method" select="'text'"/> + <xsl:with-param name="indent" select="'yes'"/> <xsl:with-param name="content"><xsl:text disable-output-escaping="yes"><![CDATA[<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN"> <HTML> <HEAD> ---------------------------------------------------------------------- >Comment By: Jirka Kosek (kosek) Date: 2005-07-30 19:13 Message: Logged In: YES user_id=189932 Thanks for patch. I will review it and commit it once I will have more time. Please stay tuned. ---------------------------------------------------------------------- Comment By: anatoly techtonik (techtonik) Date: 2005-07-17 11:28 Message: Logged In: YES user_id=669020 I remade patch from 1.68.1 version of htmlhelp-common.xsl template. Resume about modifications. * MS Help compiler is very sensitive to linefeeds, therefore an explicit declaraion of &lf; entity was written in file header to ease linebreaks for .hhc and .hhk files * <xsl:text disable-output-escaping="yes"> were replaced by native HTML markup * New template <xsl:template name="hhc.entry"> was written to reduce the burden of repeated code for .hhc generation Patch reduces filesize of htmlhelp-common.xsl by 9.2kB ---------------------------------------------------------------------- Comment By: anatoly techtonik (techtonik) Date: 2005-07-07 21:06 Message: Logged In: YES user_id=669020 All testes passed nicely on Xalan, Saxon and Xsltproc. I've attached my testing suite for windows, so you'll be able to try it on different XML. ToC and index view should be the same in .chm files from html and text mode templates. Edit .hhc file and remove some linefeeds between <object> and <param> tags to view incorrect ToC entries in resulting CHM. I've also attached patch for htmlhelp-common template. ---------------------------------------------------------------------- Comment By: anatoly techtonik (techtonik) Date: 2005-07-06 16:35 Message: Logged In: YES user_id=669020 MS Help Compiler is very sensitive to whitespaces. See comment about whitespaces on http://mail-archives.apache.org/mod_mbox/httpd-cvs/200304.mbox/%3C2...@ic...%3E I've almost finished patches to send. The difference in output for html method instead of text for every XSTL engine is in whitespaces only. I think the warning above should be included somewhere in documentation also. ---------------------------------------------------------------------- Comment By: Jirka Kosek (kosek) Date: 2005-07-05 15:35 Message: Logged In: YES user_id=189932 I see that you are just proposing to change method="text" to method="html". How this would make customizing easier? The real problem is that templates must use d-o-e to emit HTML code, because MS help complier was very sensitive in this respect. Getting rid of those d-o-e would be good, but I remember that I must use d-o-e to overcome problems in HH. There were also some problems with Xalan and I know that current code just works and I'm not very tempted by idea to refactor code and test it with different XSLT processors (read no time for this). If you can spend some time on it, please remove also all d-o-e from code and test it at least against Saxon, Xalan-J and xsltproc. If it would produce code that HH compiler can process I will apply your patch. Thanks! ---------------------------------------------------------------------- Comment By: anatoly techtonik (techtonik) Date: 2005-07-05 15:20 Message: Logged In: YES user_id=669020 Can you test this one more time? I'm almost sure you had troubles in some other part of template. I was unable to make MS htmlhelp compiler to crash or fail with this template and I'd be glad to get some proof of concept to close this patch. ---------------------------------------------------------------------- Comment By: anatoly techtonik (techtonik) Date: 2004-10-25 20:20 Message: Logged In: YES user_id=669020 Can you test this with latest HTML Help package from MS (versions 1.42 or 1.43)? These customizings seem to work well in PHP Documentation project. http://cvs.php.net/phpdoc/xsl/htmlhelp.xsl ---------------------------------------------------------------------- Comment By: Jirka Kosek (kosek) Date: 2004-10-22 22:02 Message: Logged In: YES user_id=189932 This is not possible as HTML Help compiler chokes on files that are generated with HTML output method. I don't remember these minor syntax differences, but I remember that HTML output method didn't worked and I must switch to text method to output code that was exactly expected by compiler. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=373749&aid=1048856&group_id=21935 |