Re: Patch for two issues

[Brian W. <bwe...@xb...>]

On Jul 22, 2010, at 9:12 AM, Kocik, William wrote:

> Hi -
> 
> In the course of working with DNSJava I’ve encountered two issues which are addressed by the patch below my signature:
> 
> LOCRecord.java – a LOC record with a negative altitude would cause a NumberFormatException from parseFixedPoint() when reading a zone file, because it used a regular expression that did not account for the potential presence of a ‘-’ character at the beginning of the number
This is a problem.

I modified the regex in your patch to use "-?" instead of "-{0,1}" (as they're identical), and fixed it to properly handle negative non-integers (the fractional part needs to be negated, or the result is off by one), and committed.
> ExtendedResolver.java – sendAsync() was not using its multiple resolvers to send a message, only the first one on the array.
This is the intended behavior.  Multiple requests will be sent if necessary (that is, if the first request fails or times out), but in the normal case, a single request sent using the first resolver (or a random resolver if setLoadBalance() has been called) is sufficient.

Brian