Re: Cache

[Brian W. <bwe...@xb...>]

On Wed, 20 Aug 2008, Brian Wellington wrote:

> On Wed, 20 Aug 2008, Luis Silva wrote:
>
>> 2 - You added this: "if (rcode == Rcode.NXDOMAIN) {"
>> This way you are not treating the NODATA cases. They are considered
>> referrals
>
> Good catch.  I'll try and come up with a more correct fix.

Unless I'm missing something (which is possible), changing:

 		if (soa != null || ns == null) {

to

 		if (rcode == Rcode.NXDOMAIN || soa != null || ns == null)

should be sufficient, to catch a Type 4 NXDOMAIN response.  Assuming it's 
correct, I have no problem with forgetting about the other changes and 
just committing this.

Brian