Re: Cache

[Brian W. <bwe...@xb...>]

On Wed, 20 Aug 2008, Luis Silva wrote:

> Hi again,
> After a better look I think I found this issues:
>
> 1 - You added this: "if (rcode == Rcode.NOERROR &&"
> I don't think this is necessary since in case of a NXDOMAIN error there is
> not going to be records in the answer section, with the exception of the
> CNAME records and the DNAME (I think...).

I believe this part is correct.  The intent was that if there are records 
in the answer section of an NXDOMAIN, we don't want them to be treated as 
an answer.  This won't affect CNAME/DNAME answers, as it's also checking 
"(type == qtype || qtype == Type.ANY)".

> 2 - You added this: "if (rcode == Rcode.NXDOMAIN) {"
> This way you are not treating the NODATA cases. They are considered
> referrals

Good catch.  I'll try and come up with a more correct fix.

Brian