dnsjava-users

Name: Constructor copyies too many labels

[Ingo B. <in...@ji...>]

Hey

The Name(String s, Name origin) constructor copies too many labels when
origin has been created by stripping a label.

Example code:
Name origin = Name.fromString("sub.domain.example.");
Name strippedOrigin = new Name(origin, 1);
System.out.println(new Name("prepend", strippedOrigin));

Actual output:
prepend.sub.domain.example.

Expected output:
prepend.domain.example.

Patch with new unit-test is attached.

Regards,
Ingo

Re: Name: Constructor copyies too many labels

[Brian W. <bwe...@xb...>]

On May 4, 2013, at 6:49 PM, "Ingo Bauersachs" <in...@ji...> wrote:

> Hey
> 
> The Name(String s, Name origin) constructor copies too many labels when
> origin has been created by stripping a label.
> 
> Example code:
> Name origin = Name.fromString("sub.domain.example.");
> Name strippedOrigin = new Name(origin, 1);
> System.out.println(new Name("prepend", strippedOrigin));
> 
> Actual output:
> prepend.sub.domain.example.
> 
> Expected output:
> prepend.domain.example.
> 
> Patch with new unit-test is attached.

Thanks!

I should probably make sure the same bug doesn't exist in any of the other constructors; if I don't see anything, I'll commit this and push out a new version in the next couple of days.

Brian