Re: [Dle-develop] [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock

[Seiji A. <sei...@hd...>]

> -----Original Message-----
> From: Mike Waychison [mailto:mi...@go...]
> Sent: Monday, August 20, 2012 3:17 PM
> To: Seiji Aguchi
> Cc: lin...@vg...; Luck, Tony (ton...@in...); Matthew Garrett (mj...@re...); dz...@re...; dle-
> de...@li...; Satoru Moriya
> Subject: Re: [RFC][PATCH v2 1/3] efivars: Disable external interrupt while holding efivars->lock
> 
> Acked-by: Mike Waychison <mi...@go...>
> 
> > @@ -1101,11 +1107,12 @@ out_free:
> >  void unregister_efivars(struct efivars *efivars)  {
> >         struct efivar_entry *entry, *n;
> > +       unsigned long flags;
> >
> >         list_for_each_entry_safe(entry, n, &efivars->list, list) {
> > -               spin_lock(&efivars->lock);
> > +               spin_lock_irqsave(&efivars->lock, flags);
> >                 list_del(&entry->list);
> > -               spin_unlock(&efivars->lock);
> > +               spin_unlock_irqrestore(&efivars->lock, flags);
> >                 efivar_unregister(entry);
> >         }
> >         if (efivars->new_var)
> 
> Feel free to remove any other uses of flags where you know that you
> are being called from process context.

OK. I will remove the flags from unregister_efivars(), efivar_store_raw(), efivar_create() and efivar_delete().

If I'm missing something, please let me know.

Seiji