Jbuilder, war file, and more.
Brought to you by:
dkppro
Menu
▾
▴
1st so there is no confusion, I have not gotten this to work completely yet as I am working on fixing a lot of the problems listed below. I have never worked on sourceforge and have been looking for a project like this to work on, and I do love dkp (especially auction based dkp which I am more than willing to lecture on the theoretical underpinnings of) so it seems like a fun thing to work on.
I currently do development at work in jbuilder and weblogic so I notice quite a few things lacking in the current development.
1) There is no war file or web.xml file
2) There is no pregenerated project file for jbuilder (its free from borland btw)
3) There is no support for any application server other than tomcat + mysql
4) A lot of the html is not structured correctly due to missing end tags typically. In one case editItem.jsp, it would not compile at all.
5) Dynamic includes are used instead of static includes which makes things rather ugly
6) Extensive use of hardcoded values
Some of these deficiencies I have solved, others I am working on. I would like to contribute to this project but need information on how to submit to sourceforge, what format the files should be in (unix or windows), etc. This project looks like it has a lot of potential.
I can be reached at CelandroSpellsong@hotmail.com
Celandro Spellsong the Minstrel [Triton]
Ex-60 bard povar
Thanks for the post, some comments on your points.
1) A war file would be nice to tidy things up, is a web.xml file really needed though? Currently no servlets (yes i know jsps are compiled into servlets ;) or taglibs are used etc.. what would go in the web.xml? (I still have much to learn re: serverside java so maybe i've overlooked something).
2) I use JCreator for coding, really dont like JBuilder.. too bulky for me. Prefer a nice clean simple IDE which has all the features i'd want but doesn't try and be clever and complete bits of code for me.
3) Since this was just a project I was doing in my spare time to learn serverside java I didnt really have the resources to test it on a variety of platforms. Thought orion and tomcat would be enough since they are both easily to download and install. Theoretically it should work under any app server.. guess theory and implementation are 2 different things :)
4) Just had a look and editItem.jsp is never used, its a redundant file which i'd forgot to remove. It can be deleted, i'll remove it from the next version. I agree the html needs work, a great bulk of this was done at like 4am in the morning is probably quite a bit of bad html form. All I was really concerned about was it displaying correctly under ie6 :)
5) I presume you mean the jsp includes for the top navigation bar. Originally I intended to have a seperate set of links for normal users and admin. If the admin is logged in, the string for the nav url would be changed to the string for the admin nav url instead. This redundant now though since normal users and admin share the same nav.
6) Yep. The whole thing could be coded much prettier, the thing is it was a bit of a learning experience for me as I was going along. I realise hardcoded values are a bad thing, never really expected anyone would be reading my code though so most of it is pretty messy :)
I'll try and sort out the cvs accounts, i'll send you an email when its done. You'll need to register yourself at sourceforge in able to sumbit to the cvs.
Sent you an email with responses.. Dont want to appear to be criticizing your fine work :). Just looking for a suitable pasttime :)