#14 Log successful verification/signing operations

v1.2.0
closed-accepted
3
2007-08-10
2007-07-26
Kaspar
No

As proposed on the dkim-milter-beta list:

For those running dkim-filter under Postfix, under Sendmail with MilterLogLevel below 9, or on a separate box, it would be useful to see successful verification/signing operations logged by dkim-filter, too. See the attached patch for what I have in mind - it will produce log entries like:

Jul 25 16:19:53 foobar dkim-filter[29567]: 554325394: DKIM signature successfully verified
Jul 25 18:10:31 foobar dkim-filter[27539]: 6922B538E: DKIM-Signature header successfully added

(Note that I deliberately kept the messages terse - with the header add message e.g., I didn't include the header value [though that would be available at that point in the code].)

In order to reduce overlap with Milter logging (when level > 8), one solution could be to make this kind of logging configurable.

Discussion

  • Kaspar

    Kaspar - 2007-07-26

    patch, for illustration purposes mainly

     
  • Anonymous - 2007-07-26
    • milestone: 738531 --> v1.2.0
    • assigned_to: nobody --> sm-msk
     
  • Anonymous - 2007-07-30
    • priority: 5 --> 3
     
  • Anonymous - 2007-08-01

    Logged In: YES
    user_id=1048957
    Originator: NO

    Done for 2.1.0.

     
  • Kaspar

    Kaspar - 2007-08-02

    Logged In: YES
    user_id=1854294
    Originator: YES

    > Done for 2.1.0.

    Cool, thanks! Is there a chance of getting a sneak preview of 2.1.0 (will betas be posted to SF)?

     
  • Anonymous - 2007-08-02

    Logged In: YES
    user_id=1048957
    Originator: NO

    I might re-activate the beta stuff for 2.1.0, depending on how big a release it ends up being. 2.0.0 was pretty huge but so far 2.1.0 is fairly minor.

    I'm working on 2.0.1 (bug fixes) first though.

     
  • Anonymous - 2007-08-10
    • status: open --> closed-accepted
     
  • Anonymous - 2007-08-10

    Logged In: YES
    user_id=1048957
    Originator: NO

    v2.1.0 released.

     

Log in to post a comment.