#104 dkim-genkey flags generation incorrect

v2.4.2
closed-fixed
5
2008-01-18
2008-01-09
Geoff Adams
No

The code in the dkim-genkey shell script that generates the "t=" flags list appears to be incorrect.

In particular, the sense of the "s" flag is reversed, if my reading of the spec is correct. That is, dkim-genkey includes the "s" flag when the user has *not* requested that subdomains be disabled, while the spec states that the "s" flag indicates that the key should not be used for subdomains.

Also, no ":" separator is placed between the possible "y" and "s" flags, as the spec requires. (I have not checked whether this DKIM implementation supports those flags without the colon separator, but that doesn't really matter, since other specifications should follow the spec, too.)

A little shell scripting work can easily correct these problems, assuming my analysis is correct.

Discussion

  • Anonymous - 2008-01-09
    • assigned_to: nobody --> sm-msk
     
  • Anonymous - 2008-01-09

    Proposed patch #1

     
  • Anonymous - 2008-01-09

    Logged In: YES
    user_id=1048957
    Originator: NO

    Quite right. Try the attached patch. You will also need to apply the patch found in bug #1867259 to get this one to apply since that one overlaps with this one.

    If you have trouble with it, let me know and I can post the entire (patched) file.
    File Added: PATCH

     
  • Anonymous - 2008-01-18

    Logged In: YES
    user_id=1048957
    Originator: NO

    Patch included in 2.4.3, now released.

     
  • Anonymous - 2008-01-18
    • status: open --> closed-fixed
     

Log in to post a comment.