I added a small useful feature to the djview4. Could you please review this patch?
Attached patch allows to use pinch zoom gesture to fine adjust zoom level. It does not conflict with mouse wheel zooming. Behaviour is available for Qt 4.6 and disabled by macro check for earlier versions. Tested on OS X 10.10, Qt 4.8.6 and djview 4.10.2 (master branch).
Also made a pull request because a message did not show up for twenty
minutes. Sorry for the duplicate.
A variant of your code is in git (tested with qt-5.2). I had to be more
careful about canceled gestures and about the cumulative effect of pinch
updates. I wish it worked under linux.
L.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
A little off-topic. I help maintaining djview at Homebrew. I saw a git tag for version 4.10.2 that fixes some critical build issues on OS X. Sf.net "Files" section does not contain this release. Is it an official or intermediate version? Could this release be placed at "Files"?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This is a tag in git.
Do you actually need a file for homebrew or can you target a git tag?
I have a question about homebrew. My mac has a haswell processor with plenty of new instructions (avx2, etc.) But I do not want homebrew to compile for this processor only because I use it to generate distributable binaries. I had to hack the homebrew code to prevent tuning for the machine (both the std and super envs), essentially pretending that I am building bottles. Is there a better way to achieve this?
A little off-topic. I help maintaining djview at Homebrew. I saw a git tag for version 4.10.2 that fixes some critical build issues on OS X. Sf.net "Files" section does not contain this release. Is it an official or intermediate version? Could this release be placed at "Files"?
For the Homebrew it's probably better to have an official release with a tarball. Using a git tag for a unreleased version is not widely used. Now I am using a 4.10 release and a few patches.
You can build on your machine a portable binary targetting older CPU (core2 for 64-bit or core for 32-bit systems) by building a bottle. Easiest way is using the --build-bottle, for example brew install --build-bottle djview4.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
For the Homebrew it's probably better to have an official release with a tarball. Using a git tag for a unreleased version is not widely used. Now I am using a 4.10 release and a few patches.
You can build on your machine a portable binary targetting older CPU (core2 for 64-bit or core for 32-bit systems) by building a bottle. Easiest way is using the --build-bottle, for example brew install --build-bottle djview4.
Also you can pass the configure arguments to autogen.sh and let it do everything.
Note that djvulibre also moved to automate, using the same script.
- L.
Hello,
I added a small useful feature to the djview4. Could you please review this patch?
Attached patch allows to use pinch zoom gesture to fine adjust zoom level. It does not conflict with mouse wheel zooming. Behaviour is available for Qt 4.6 and disabled by macro check for earlier versions. Tested on OS X 10.10, Qt 4.8.6 and djview 4.10.2 (master branch).
Best regards,
Eugene Seliverstov
Also made a pull request because a message did not show up for twenty minutes. Sorry for the duplicate.
On Monday, April 13, 2015 11:14:31 PM irix wrote:
A variant of your code is in git (tested with qt-5.2). I had to be more
careful about canceled gestures and about the cumulative effect of pinch
updates. I wish it worked under linux.
Thank you. Checked latest commit, it works on Mac, cannot check Linux (no multitouch trackpad).
A little off-topic. I help maintaining djview at Homebrew. I saw a git tag for version 4.10.2 that fixes some critical build issues on OS X. Sf.net "Files" section does not contain this release. Is it an official or intermediate version? Could this release be placed at "Files"?
This is a tag in git.
Do you actually need a file for homebrew or can you target a git tag?
I have a question about homebrew. My mac has a haswell processor with plenty of new instructions (avx2, etc.) But I do not want homebrew to compile for this processor only because I use it to generate distributable binaries. I had to hack the homebrew code to prevent tuning for the machine (both the std and super envs), essentially pretending that I am building bottles. Is there a better way to achieve this?
On Apr 14, 2015, at 11:28 AM, irix theirix@users.sf.net wrote:
For the Homebrew it's probably better to have an official release with a tarball. Using a git tag for a unreleased version is not widely used. Now I am using a 4.10 release and a few patches.
You can build on your machine a portable binary targetting older CPU (core2 for 64-bit or core for 32-bit systems) by building a bottle. Easiest way is using the
--build-bottle, for examplebrew install --build-bottle djview4.I'll put a 4.10.2 out soon.
Can I see your brew recipes somewhere (mine still uses 4.8).
Best,
- L.
Thank you, it would be nice as it will remove unneeded patches in the homebrew recipe.
My pull request on 4.10 is here https://github.com/Homebrew/homebrew/pull/38594
Also you can pass the configure arguments to autogen.sh and let it do everything.
Note that djvulibre also moved to automate, using the same script.
- L.
Yes, I noticed it, very convenient. I followed the way separating autogen and configure calls for consistency with other Homebrew recipes.
Just added djview-4.10.3.tar.gz with pinch support as well.
- L.