Re: [Distel-hackers] who_calls rewrite

[Bill C. <bil...@gm...>]

Hi Matthias,

Matthias Radestock <mat...@so...> writes:
> Bill Clementson wrote:
>
>> Very nice. This is much faster and (with my limited testing) seems to
>> produce the same results. I've committed your patch.
>
> Cheers.
>
> On a related note, who_calls actually returns the line number of the
> call sites but this currently isn't displayed/used. This was the case
> in the previous version too.
>
> There is a comment in the code saying "FIXME: Use line number for a
> hyperlink.". I reckon one way to implement something sensible along
> these lines is to construct an, in Emacs-lingo, "overlay" for the
> displayed m:f/a with the line number information. 

I thought that "overlays" were more for display properties and that
"text-properties" would be what you would want to use for storing the
line# and source file of any matches.

> We can then look for
> this invisible piece of information in "M-." (aka
> erl-find-source-under-point) and, if present, navigate to it.
>
> Any other suggestions?

Are you suggesting that "M-." be used to go to the "call"? Normally,
"M-." is used to go to the definition, not a reference. Why not just
use "RET"? You could have a separate RET key binding for the who-calls
results buffer.

- Bill