In src/appfunctions.c, line 1519, the declaration of
*sambaSID is NOT initialized and therefore causes the
program to abort when accessing a user for editing.
Changing it to
gchar *sambaSID = NULL;
fixes the problem because the next check catches null sids
and thus prevents the abort.
Regards,
M. Browning
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
This patch contains a lot of cosmetic (indentation, spacing)
changes, which should not go together with functional
changes. I'll clean it up and fix the problem signalled by
M. Browning (his fix is wrong, unfortunately).
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Unfortunately this patch is a fundamental rewrite of a lot
of the code, where it is not practical to split out white
space changes with the code changes. Supporting Samba3 is
not trivial, there is a lot more information about a Windows
domain stored in a Samba3 LDAP directory than there ever was
in Samba2.
If this patch is committed, I would suggest creating a new
branch for it, as it isn't that easy to support Samba2 and
Samba3 at the same time.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Samba v3.0 / Email aliases / Extended password
New Patch to support Windows DOmain system groups
Logged In: NO
In src/appfunctions.c, line 1519, the declaration of
*sambaSID is NOT initialized and therefore causes the
program to abort when accessing a user for editing.
Changing it to
gchar *sambaSID = NULL;
fixes the problem because the next check catches null sids
and thus prevents the abort.
Regards,
M. Browning
Logged In: YES
user_id=95198
I have confirmation that this (along with M. Browning's fix)
mostly works, so I'll try and get it into the mainline tree,
thanks. :)
Logged In: YES
user_id=104300
This patch contains a lot of cosmetic (indentation, spacing)
changes, which should not go together with functional
changes. I'll clean it up and fix the problem signalled by
M. Browning (his fix is wrong, unfortunately).
Logged In: YES
user_id=129704
Unfortunately this patch is a fundamental rewrite of a lot
of the code, where it is not practical to split out white
space changes with the code changes. Supporting Samba3 is
not trivial, there is a lot more information about a Windows
domain stored in a Samba3 LDAP directory than there ever was
in Samba2.
If this patch is committed, I would suggest creating a new
branch for it, as it isn't that easy to support Samba2 and
Samba3 at the same time.