Dirac / Patches / #33 Fix improper namespace usage on Win32

#33 Fix improper namespace usage on Win32

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2009-08-25

Created: 2009-08-25

Creator: LRN

Private: No

setstdiomode.cpp is broken: first it says "namespace dirac_vu", and then it conditionally includes some C headers. AFAIK it's a bad idea to include headers within namespace, unless you want all the respective functions to go into your namespace. Which is what happens at the moment. And that results in _fileno() becoming an undefined symbol at link-time.

Patch attached.

Discussion

LRN - 2009-08-25

Fix improper namespace usage on Win32

0001-Fix-improper-namespace-usage-on-Win32.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Fix improper namespace usage on Win32

Group

Searches

Help

#33 Fix improper namespace usage on Win32

Discussion