Typo in libdirac_common/upconvert.cpp

[Eric RANNAUD]

[both in CVS and 0.4.3]
From line 73:
            sum += (OldImage[((y-1)>=0)?(y-1):0][x] + OldImage[y+2][x])*StageI_II;
            sum += (OldImage[((y-2)>=0)?(y-1):0][x] + OldImage[y+3][x])*StageI_III;
            sum += (OldImage[((y-3)>=0)?(y-1):0][x] + OldImage[y+4][x])*StageI_IV;
            sum += (OldImage[((y-4)>=0)?(y-1):0][x] + OldImage[y+5][x])*StageI_V;
            sum += (OldImage[((y-5)>=0)?(y-1):0][x] + OldImage[y+6][x])*StageI_VI;

Shouldn't this be:
            sum += (OldImage[((y-1)>=0)?(y-1):0][x] + OldImage[y+2][x])*StageI_II;
            sum += (OldImage[((y-2)>=0)?(y-2):0][x] + OldImage[y+3][x])*StageI_III;
            sum += (OldImage[((y-3)>=0)?(y-3):0][x] + OldImage[y+4][x])*StageI_IV;
            sum += (OldImage[((y-4)>=0)?(y-4):0][x] + OldImage[y+5][x])*StageI_V;
            sum += (OldImage[((y-5)>=0)?(y-5):0][x] + OldImage[y+6][x])*StageI_VI;

That is: the case true shouldn't be constant equals to (y-1).

Or maybe I'm wrong on that, if so, could somebody explain why this is asymetric?

[Thomas Davies]

Yes, that's a bug. Will fix.

Thomas