#36 A couple of bugs in Motion Estimation for BoundsChecking

closed-fixed
nobody
5
2006-01-06
2005-12-17
Steve
No

In trying some changes I noticed the following 2 bugs
in the me_utils file.

This is for the none MMX case, the MMX case appears to
generate different files so I am assuming there are
other issues in that.

In

void BlockDiffQuarterPel::Diff( const BlockDiffParams&
dparams,
const MVector& mv ,
const float mvcost,
const float lambda,
MvCostData&
best_costs ,
MVector& best_mv)

the bound check case the x, y params are not correct
and should be as in the previous QuarterPel Diff
routine for bounds checking, uses m_pic_data[y][x] but
x,y are using dparams.Xl() instead of dparams.Xp().

also in BiBlockQuarterPel::Diff

the second reference uses ref_start1 instead of
ref_start2 in the bounds_check case.

I'll try and produce a patch for this at some point
over the weekend.

Discussion

  • Steve

    Steve - 2005-12-17
    • summary: A couple of bugs in Diff for BoundsChecking cases --> A couple of bugs in Motion Estimation for BoundsChecking
     
  • Steve

    Steve - 2005-12-17

    Patch for bugs

     
  • Anuradha Suraparaju

    Logged In: YES
    user_id=692051

    Applied the patch supplied in the bug report.
    File modified:
    me_utils.cpp - new revision: 1.17; previous revision: 1.16

     
  • Anuradha Suraparaju

    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks