Re: [DIGImend-devel] [PATCH] hid-waltop: Add Mars A graphics tablet
Brought to you by:
spb_nick
From: Rüdiger S. <r.s...@go...> - 2016-11-08 15:36:23
|
Hi, I've used a Debian 4.7 Src Package, but i can apply the patch to the tree you prefer. I thought it's possible without git for this small patch, mea culpa. At the moment I'm doing a git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and awaiting your suggestions. Rüdiger Am 08.11.2016 um 15:50 schrieb Jiri Kosina: > On Tue, 8 Nov 2016, Rüdiger Schneider wrote: > >> hope comments are better now and the patch is no more crippled. > > It unfortunately is, somehow your MUA added a leading space to the patch. > Did you even try to apply this using git? > > Also, which tree is this based on? Context in hid-waltop.c file suggests > that there should be context at offset +268 > > /* > * See Media Tablet 10.6 inch description, device and HID report descriptors at > * http://sf.net/apps/mediawiki/digimend/?title=Waltop_Media_Tablet_10.6%22 > > but I don't see that in my tree. > > Regarding changelog -- I'd suggest simply something along the lines of > > "Replace report descriptor to make the 2 stylus buttons report button > presses correctly; without this change, both stylus button incorrectly > report the same event." > |