Re: [DIGImend-devel] [PATCH v2] uc-logic: tweak the pad report descriptor for it to work with xf86-input-wacom

[Nikolai K. <sp...@gm...>]

On 03/18/2015 10:24 PM, Benjamin Tissoires wrote:
> To have legacy xf86-input-wacom accepting the pad of the Huion tablets,
> we need to set some bits on the Pad interface even if they are not used.
>
> The following bits are activated:
> - ABS_MISC   -> Digitizers | 0xff
> - ABS_X      -> Generic Desktop | X
> - ABS_Y      -> Generic Desktop | Y
> - BTN_STYLUS -> Digitizers | Barrel Switch
> (because the Pad used to be a attached to the stylus interface, libwacom
>   and others expect the Pad to look like a tablet)
>
> Not having the xf86-input-wacom driver handling the pad is not a
> regression, so there is no absolute need for it upstream.
> Plus, a device should not export axes it does not have.
> It however makes sense to include this in the digimend-kernel-tree drivers
> given that the purpose is to have users try the drivers with their current
> setup.
>
> Note that if we add the BTN_RUBBER capability to the Pen interface,
> gnome-control-center happily takes the device. However, this will break
> users who have updated libwacom to current master, so better not export
> such false capability.

Looks good, thanks Benjamin! Merged with a shortened subject.

Nick