Re: [DIGImend-devel] Support for Genius PenSketch M912 (take two)

[Nikolai K. <sp...@gm...>]

Hi Milan,

On 01/18/2015 08:47 PM, Milan Plžík wrote:
> thank you for your comments. I added the missing <pop/> element. With the
> 'digitizer eraser' button, I hoped to temporarily switch a tool to eraser,
> but as you noted, that did not work. I reverted it to AC Delete, which is
> probably the closest description I could find in the HID Usage Tables
> document. Attached is both the kernel patch to current master and the fixed
> descriptor XML.

Sorry for another delay. I think it is fine. Even though the button functions
don't match the pictures beside them exactly, it is more important for them to
be actually useful to users.

With regards to actually contributing this, I think with this patch quality
you can go directly to the kernel maintainers.

Send this patch (with "git send-email", if you can) to Jiri Kosina
<jk...@su...> and CC it to lin...@vg.... Please also CC
dig...@li... and me and I'll put my Reviewed-by on it,
FWIW.

Thanks a lot for your work!

Another good thing to do would be contributing this to digimend-kernel-drivers
[1] as well, so users of older kernel versions can use it sooner/more easily.

Regarding the report descriptor XML, I'd like to note that you can use the
"PUSH" (uppercase) element instead of the "push"/"pop" element pair to make it
standout more. But if you don't plan to write any more report descriptor in
hidrd XML, it shouldn't matter to you :)

Regarding the buttons, I've experimented a little with making the hid-huion.c
driver report generic button presses [2], which can then be remapped by
xf86-input-wacom, but hasn't arrived to a good compatible solution yet.
Perhaps you can take some ideas from there to improve your tablet button
mapping.

Nick

[1] https://github.com/DIGImend/digimend-kernel-drivers
[2] https://github.com/DIGImend/digimend-kernel-drivers/tree/huion-abstract-keyboard