Re: [DIGImend-devel] [PATCH] hid: huion: Fix sparse warnings

[Nikolai K. <sp...@gm...>]

On 07/29/2014 04:06 PM, Jiri Kosina wrote:
> On Tue, 29 Jul 2014, Nikolai Kondrashov wrote:
>
>> Fix sparse warnings in hid-huion.c by using correct buffer type for
>> retrieved string descriptor.
>>
>> The warnings in question were:
>>
>>      drivers/hid/hid-huion.c:144:44: sparse: cast to restricted __le16
>>      drivers/hid/hid-huion.c:145:44: sparse: cast to restricted __le16
>>      drivers/hid/hid-huion.c:146:51: sparse: cast to restricted __le16
>>      drivers/hid/hid-huion.c:147:30: sparse: cast to restricted __le16
>
> Interestingly enough, my sparse doesn't seem to report this problem
> (running sparse is part of my machinery before pushing anything out).

The above only appears with CF=-D__CHECK_ENDIAN__.

>> If you wouldn't like adding a tiny patch like this, I can send another version
>> of the original patches. Otherwise, please feel free to just fixup my "Switch
>> to generating report descriptor" commit with this one.
>
> Yup, I'll be applying this on top of your previous one.

Thanks!

Nick