Re: [DIGImend-devel] [PATCH 2/5] hid: huion: Invert in-range on specific product

[Nikolai K. <sp...@gm...>]

On 07/23/2014 05:34 PM, Benjamin Tissoires wrote:
> On Wed, Jul 23, 2014 at 8:42 AM, Nikolai Kondrashov <sp...@gm...> wrote:
>> Limit inverting the in-range bit in raw reports to tablet product ID
>> only. This will make adding handling of other, non-tablet products,
>> easier.
>>
>> Signed-off-by: Nikolai Kondrashov <sp...@gm...>
>> ---
>
> I am not particularly a big fan of this one. You are here adding a
> test which will be called at each raw_event but currently only tablet
> products are bound to hid-huion. Even in the rest of the series, you
> add another VID/PID, but it still has the same PID.
>
> So I would say that this will be nice to have when we really have the
> problem, not now.
>
> But if you tell me that you already have the need for it, I am fine
> with it. It's just that this commit message + the rest of the patch
> series makes me feel like this is just a superflous test.
>
> So, in its current state:
> NACK

I had doubts about this one myself, but left it in just for consistency with
some other drivers. I'll drop it in the next version then.

Thank you.

Nick