#7 'diffuse -m' specifying deleted file silently fails

closed-fixed
nobody
None
5
2011-05-25
2011-05-16
DiGiT
No

Running 'diffuse -m bar.txt' when 'bar.txt' has been deleted displays nothing. Running 'diffuse -m foodir' where 'foodir' is the directory in which 'bar.txt' lived works as expected and displays a diff for bar.txt. I'm using subversion.

Steps to reproduce:
1) svn mkdir foodir
2) Create a file, foodir/bar.txt with some text in it.
3) svn add foodir/bar.txt
4) svn commit
5) svn del foodir/bar.txt
6) diffuse -m foodir/bar.txt ... nothing happens
7) diffuse -m foodir ... displays diff for bar.txt

This might seem like a pointless feature, but it would be quite useful to me when having others review my changes using diffuse. Just running 'diffuse -m' would work, but it displays every changed file and sometimes I want to filter out some changed directories by manually specifying the files to diff.

Discussion

  • DiGiT

    DiGiT - 2011-05-16

    Based on a look through the code, I think this is caused by line 7004 in diffuse 0.4.4. Diffuse checks whether the path is a file, but since the file is deleted the check fails and diffuse assumes the path is a directory.

     
  • Derrick Moser

    Derrick Moser - 2011-05-22

    This should now be fixed in the development version if you care to test it.

     
  • DiGiT

    DiGiT - 2011-05-24

    Just tested on svn, looks good. Thanks for the quick response!

     
  • Derrick Moser

    Derrick Moser - 2011-05-25
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks