Menu

#29 [java] Generate void return type, if operation type is empty, and it's no constructor

None
closed
None
4
2021-12-27
2017-01-05
David
No

Hi,

as noted in README, dia2code won't generate operation return types, if the operation type is empty. This works for constructors but breaks ordinary functions. I don't think this is the right choice, as one needs to rework many function in order to get the code to compile.

Therefore I changed the implementation for the java code generator to generate a void return type, if the operation is no constructor. Unfortunally I don't have time to fix this in all languages, but maybe you're nevertheless interested in the change.

1 Attachments

Discussion

  • David

    David - 2017-01-05

    New version of the patch attached, there were issues with the diff.

     
  • Oliver Kellogg

    Oliver Kellogg - 2017-01-05
    • status: open --> accepted
    • assigned_to: Oliver Kellogg
    • Group: -->
     
  • Oliver Kellogg

    Oliver Kellogg - 2017-01-05

    Thanks for your patch, I applied it in commit ff451b4.

     
  • Oliver Kellogg

    Oliver Kellogg - 2021-12-27
    • status: accepted --> closed
     

Log in to post a comment.