Menu

#26 various segfaults

None
accepted
nobody
None
1
2016-07-11
2016-01-10
ooo
No

I've encountered a few problems with dia2code, so I forked it and fixed a few things.
If anyone is interested: https://github.com/lovasoa/dia2code/commits/master

1 Attachments

Discussion

  • LE GARREC Vincent

    Hi,

    I took a look at your diff. Looks good for me. I'm not an expert with SQL so I guess your modification about primary key is fine.
    Just one thing : I think next version will be 0.8.9. they are just bug fix.

    Can you help me with git ? How can I import all you commit from github to sf ? otherwise, I will just apply your big diff.

    Last thing : I only have a devel account, I'm not allow to do release. Only Kellogg can do it. Hope he's still somewhere…

    PS : One year ago, I created a branch (dia2code-c++) where I made changes in dia2code with tests. But I only know cpp, csharp, java and php. If you have time, maybe you could help me to add sql in this new version.

     
    • Oliver Kellogg

      Oliver Kellogg - 2016-01-20

      Last thing : I only have a devel account, I'm not allow to do release.
      Only Kellogg can do it. Hope he's still somewhere…

      Yes, I'm "somewhat" there although I am finding very little time these days for dia2code.
      Thanks for the patches.
      It may take a few weeks until I get around to integrating them.
      Vincent: If you would like to go ahead with this then I can also grant you the release privileges.

       
      • LE GARREC Vincent

        Hi Oliver,

        Sometimes I have tough words but I never want to be hurtful. I just wanted to say that if you disappeared, this project will be lost in sf. So, thanks, I will be glad if I can have release privileges.

        Vincent

         
  • ooo

    ooo - 2016-01-16

    I'm not an expert either. But here is a list of consecutive diffs, generated with
    git whatchanged -p 80451a^.. > /tmp/consecutive-diffs.txt.
    Maybe it can help you import things in an automated way.

    There are not only bugfixes. I also added the ability to import database diagrams. This is a different kind of diagrams that Dia can generate.

     
    • LE GARREC Vincent

      I just tried to import your diff but I discovered you used the CVS as base but it's out of date. Only the git source it up to date. Does it bother you to make modification again but based on git ? Thanks.

      Oliver, can you delete the CVS source to avoid this problem in future ? Thanks again.

      Vincent

       
      • ooo

        ooo - 2016-01-21

        OK, I will do that. But there are quite a lot of conflicts and I don't have a lot of time, so it may not come today...

         
      • ooo

        ooo - 2016-01-21

        Here it is! Merged! Working with git is really handy. Now you just have to merge that:
        https://github.com/lovasoa/dia2code/commits/lovasoa_patches

        I made a branch for the merge.

         
        • LE GARREC Vincent

          Thanks, I will merge it this week-end.
          I didn't know that github could manage branch from git not on github.

           
          • ooo

            ooo - 2016-01-21

            Github's git repositories support all features of git :) And as git is distributed by nature, you can merge changes from any other git repository :)

             
  • ooo

    ooo - 2016-01-21

    I think dia2code's website should be updated too. It also proposes to download out-of-date sources directly from the site as a tarball.

     
  • ooo

    ooo - 2016-02-06

    Anything new here ?

     
  • Oliver Kellogg

    Oliver Kellogg - 2016-07-11
    • status: open --> accepted
    • Group: -->
     
  • Oliver Kellogg

    Oliver Kellogg - 2016-07-11

    Vincent, I believe this patch has been applied?
    Thanks.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.