Menu

#4 Patches for VGM music dumping support and basic Sega Pico support

v1.33
closed-fixed
None
5
2014-07-27
2013-08-10
nextvolume
No

I am attaching two patches, one adds VGM music dumping support and basic Sega Pico support, and another patches the dgen.1 manual file to add information about the new command "vgmdump" used to manage to VGM music dumping.

The patches are as generated by git format-patch

1 Attachments

Discussion

  • A. Normal

    A. Normal - 2013-12-12
    • status: open --> pending
    • assigned_to: A. Normal
     
  • A. Normal

    A. Normal - 2013-12-12

    Hi, sorry for the long delay.

    Thanks for these patches, I didn't even know about the Pico before you created this ticket, and VGM dumping support is nice. After a quick review, I'm willing to include them in DGen/SDL, however I think they need some modifications:

    • Split VGM and Pico support in two different commits.
    • VGM documentation should be part of the VGM commit.
    • Each commit should contain your signed-off-by line, a title and
      a more complete description of what it does. See previous commits.
    • Please remove trailing spaces (though I can fix that later).

    Since I haven't tested it yet, how well do Pico games run in DGen/SDL?

    Thanks.

     
  • A. Normal

    A. Normal - 2014-07-27
    • status: pending --> closed-fixed
    • Group: Current --> v1.33
     
  • A. Normal

    A. Normal - 2014-07-27

    Features included in the 1.33 release, closing ticket.

     

Log in to post a comment.

MongoDB Logo MongoDB