Menu

#24 Setting bool_swab in the configuration file is ineffective

Current
unread
nobody
None
5
2015-12-10
2015-12-10
ichigo-0
No

I've looked into it a bit, and there seem to be two related issues (both in sdl/sdl.cpp) each of which causes the swab filter to not be active, even if bool_swab is set to true in the configuration file.

First, filters_insert(), which is used to add the swab filter, places the new filter in position 0, and then calls filters_stack_update(). The latter function removes the default filter if it is present and there is now at least one other filter. However, this function assumes the default filter is in position 0. Since the swab filter is added while the stack is empty, the result is that it is immediately removed.

Second, filters_pluck_ctv() removes the swab filter. Now, perhaps this is intentional, however the problem is that the bool_swab setting is not considered when re-adding the active ctv filter afterward.

There are at least two workarounds. First, one can type :bool_swab true while running DGen to activate this option from the prompt. Alternatively, one can use ctv_craptv_startup = swab in the configuration file.

I've also attached a patch that should fix both problems.

1 Attachments

Discussion


Log in to post a comment.