Re: [Devmon] CVS commits?

[Dan V. M. <bi...@gm...>]

FYI, this patch introduces a bug, anyone who applies to should pay
close attention to this:

-          $line =3D~ s/\|/<\/td><td>/g;
-          $table .=3D "<tr><td>$line</td></tr>";
+          if($tabletype eq 'html') {
+            $table .=3D "<tr><td>$line</td></tr>\n";
+            $line =3D~ s/\|/<\/td><td>/g;


Notice it changes the order of substitutions. If you're seeing your
HTML table headers being messed up, change lines 39 and 40 around in
the patch (or 1460 and 1461 in the new dm_tests.pm) so the
substitutions are performmed in the correct order.

-Dan

On 3/10/06, Dan Vande More <bi...@gm...> wrote:
> This is great. I am seeing exactly what I expected, and will now try
> to get it graphing.
>
> On 3/10/06, Schwimmer, Eric E *HS <EE...@hs...> wrote:
> >
> > Ah my bad, I manually edited the patch and forgot to correct the line
> > range, as
> > I had to remove something that was added by an ealier patch (the one
> > that fixed
> > the alarm priority).  Meh.
> >
> > -Eric
> >
> > > -----Original Message-----
> > > From: dev...@li...
> > > [mailto:dev...@li...] On Behalf
> > > Of Dan Vande More
> > > Sent: Friday, March 10, 2006 4:01 PM
> > > To: dev...@li...
> > > Subject: Re: [Devmon] CVS commits?
> > >
> > > I got it to patch successfully by removing this hunk from the patch:
> > >
> > > @@ -1476,14 +1492,15 @@
> > >          T_LEAF: for my $leaf (sort {$a <=3D> $b} keys
> > > %{$oids->{$pri}{'val'}}) {
> > >
> > >            my $row_data =3D $line;
> > > +          my $leafrrd  =3D '';
> > >
> > >           # Do some alarm logic
> > >            my $pri_val =3D $oids->{$pri}{'val'}{$leaf};
> > >
> > > and added the leafrrd line myself. As for why it didn't work, I'm not
> > > even going to guess.
> > >
> > > Thanks
> > >
> > > Dan
> > >
> > > On 3/10/06, Dan Vande More <bi...@gm...> wrote:
> > > > Sorry for being a noob, but I'm getting this with that patch:
> > > >
> > > > ~$ patch -p 0 < patch-nonhtmltables_rrddump
> > > > patching file modules/dm_tests.pm
> > > > patch: **** malformed patch at line 68: @@ -1526,6 +1543,7 @@
> > > >
> > > > Here are lines 67, 68 and 69:
> > > >
> > > >            my $pri_val =3D $oids->{$pri}{'val'}{$leaf};
> > > > @@ -1526,6 +1543,7 @@
> > > >              if($oid eq $pri and $alarm) {
> > > >
> > > >
> > > > Thanks
> > > >
> > > > Dan
> > > >
> > > >
> > > > On 3/10/06, Dan Vande More <bi...@gm...> wrote:
> > > > > Well I was thinking, for example, of doing something like
> > > this in the
> > > > > message file for if_load:
> > > > >
> > > > > ---
> > > > > Interface error rates:
> > > > > TABLE:
> > > > > Ifc name|Ifc Speed|Rate in (load %)|Rate out (load %)
> > > > > {ifName}{ifAliasBox}|{ifSpeed}|{ifInLoad.color}{ifInSpeed}
> > > > > ({ifInLoad}%){ifInLoad.errors}|{ifOutLoad.color}{ifOutSpeed}
> > > > > ({ifOutLoad}%){ifOutLoad.errors}
> > > > >
> > > > > NONHTMLTABLE:
> > > > > ifInLoad : {ifInLoad}
> > > > > ifOutLoad: {ifOutLoad}
> > > > > ---
> > > > >
> > > > > So there wouldn't be any column separators per se, unless
> > > I put them
> > > > > in. Of course, depending on how many tests you're performing, you=
r
> > > > > message file would get pretty big. But I think this solves two
> > > > > problems - NCV support & Non-HTML email support. People
> > > who don't want
> > > > > HTML in their email for tests can simply change their
> > > "message" file
> > > > > from TABLE to NONHTMLTABLE.
> > > > >
> > > > > For NCV we just need to make sure there's nothing else on
> > > the lines
> > > > > containing "foo : bar", as then hobbit won't detect it as a line
> > > > > that's candidate for having NCV data. I suppose too that you coul=
d
> > > > > throw some <!--/--> stuff when the NONHTMLTABLE begins
> > > and end so the
> > > > > data on the webpage isn't bloated and redundant.
> > > > >
> > > > > Does that make sense?
> > > > >
> > > > > Dan
> > > > >
> > > > >
> > > > > On 3/10/06, Schwimmer, Eric E *HS
> > > <EE...@hs...> wrote:
> > > > > >
> > > > > > How do you want the columns separated?  Whitespace? Commas?
> > > > > >
> > > > > > -Eric
> > > > > >
> > > > > > > -----Original Message-----
> > > > > > > From: dev...@li...
> > > > > > > [mailto:dev...@li...] On Behalf
> > > > > > > Of Dan Vande More
> > > > > > > Sent: Friday, March 10, 2006 2:14 PM
> > > > > > > To: dev...@li...
> > > > > > > Subject: Re: [Devmon] CVS commits?
> > > > > > >
> > > > > > > Oh, wow, figured the same thing (SF said no update
> > > this month). Glad
> > > > > > > to hear that's not the case.
> > > > > > >
> > > > > > > Eric, you're understandably busy, but have you got a chance t=
o
> > > > > > > consider any NONHTMLTABLE (Or similiar) options that
> > > might allow me to
> > > > > > > come up with a way to push NCV data?
> > > > > > >
> > > > > > > If the lines weren't surrounded with HTML, hobbit
> > > could see output as
> > > > > > > NCV format and graph without you doing anything
> > > custom (Like a hobbit
> > > > > > > patch for each datatype, etc).
> > > > > > >
> > > > > > > Thanks
> > > > > > >
> > > > > > > Dan
> > > > > > >
> > > > > > > On 3/10/06, Schwimmer, Eric E *HS
> > > > > > > <EE...@hs...> wrote:
> > > > > > > >
> > > > > > > > Sourceforge lies!  All lies!  The latest and greatest code
> > > > > > > is up there,
> > > > > > > > with the exception of the patches I have sent out today.
> > > > > > > >
> > > > > > > > Hrm, external CVS would probably be a good idea. I'll see
> > > > > > > about setting
> > > > > > > > it up.
> > > > > > > >
> > > > > > > > -Eric
> > > > > > > >
> > > > > > > > > -----Original Message-----
> > > > > > > > > From: dev...@li...
> > > > > > > > >
> > > [mailto:dev...@li...] On Behalf
> > > > > > > > > Of Bill Finizia
> > > > > > > > > Sent: Friday, March 10, 2006 1:02 PM
> > > > > > > > > To: dev...@li...
> > > > > > > > > Subject: [Devmon] CVS commits?
> > > > > > > > >
> > > > > > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > > > > > Hash: SHA1
> > > > > > > > >
> > > > > > > > > Hi
> > > > > > > > >
> > > > > > > > > Are any of these new templates and code updates
> > > going to be
> > > > > > > > > stored in
> > > > > > > > > a central location?  I checked on SF and nothing seems to
> > > > > > > have been
> > > > > > > > > added this month.
> > > > > > > > >
> > > > > > > > > Bill Finizia
> > > > > > > > >
> > > > > > > > > -----BEGIN PGP SIGNATURE-----
> > > > > > > > > Version: GnuPG v1.4.1 (Darwin)
> > > > > > > > >
> > > > > > > > >
> > > iD8DBQFEEb8s/Ol32NgyEZgRAgSpAKCQVkKtmHjS745LgYwEv64M81jmUQCdFkMX
> > > > > > > > > MgUy501i0l4Iu5ixKPS3dO0=3D
> > > > > > > > > =3DHAgk
> > > > > > > > > -----END PGP SIGNATURE-----
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > -------------------------------------------------------
> > > > > > > > > This SF.Net email is sponsored by xPML, a groundbreaking
> > > > > > > > > scripting language
> > > > > > > > > that extends applications into web and mobile
> > > media. Attend
> > > > > > > > > the live webcast
> > > > > > > > > and join the prime developer group breaking into this new
> > > > > > > > > coding territory!
> > > > > > > > >
> > > http://sel.as-us.falkag.net/sel?cmd=3Dlnk&kid=3D110944&bid=3D241720&
> > > > > > > > dat=3D121642
> > > > > > > > > _______________________________________________
> > > > > > > > > Devmon-support mailing list
> > > > > > > > > Dev...@li...
> > > > > > > > >
> > > https://lists.sourceforge.net/lists/listinfo/devmon-support
> > > > > > > > >
> > > > > > > >
> > > > > > > >
> > > > > > > > -------------------------------------------------------
> > > > > > > > This SF.Net email is sponsored by xPML, a groundbreaking
> > > > > > > scripting language
> > > > > > > > that extends applications into web and mobile media. Attend
> > > > > > > the live webcast
> > > > > > > > and join the prime developer group breaking into this new
> > > > > > > coding territory!
> > > > > > > >
> > > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642
> > > > > > > > _______________________________________________
> > > > > > > > Devmon-support mailing list
> > > > > > > > Dev...@li...
> > > > > > > > https://lists.sourceforge.net/lists/listinfo/devmon-support
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > -------------------------------------------------------
> > > > > > > This SF.Net email is sponsored by xPML, a groundbreaking
> > > > > > > scripting language
> > > > > > > that extends applications into web and mobile media. Attend
> > > > > > > the live webcast
> > > > > > > and join the prime developer group breaking into this new
> > > > > > > coding territory!
> > > > > > >
> > > http://sel.as-us.falkag.net/sel?cmd=3Dk&kid=110944&bid$1720&dat=12164=
2
> > > > > > > _______________________________________________
> > > > > > > Devmon-support mailing list
> > > > > > > Dev...@li...
> > > > > > > https://lists.sourceforge.net/lists/listinfo/devmon-support
> > > > > > >
> > > > > >
> > > > > >
> > > > > > -------------------------------------------------------
> > > > > > This SF.Net email is sponsored by xPML, a
> > > groundbreaking scripting language
> > > > > > that extends applications into web and mobile media.
> > > Attend the live webcast
> > > > > > and join the prime developer group breaking into this
> > > new coding territory!
> > > > > >
> > > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642
> > > > > > _______________________________________________
> > > > > > Devmon-support mailing list
> > > > > > Dev...@li...
> > > > > > https://lists.sourceforge.net/lists/listinfo/devmon-support
> > > > > >
> > > > >
> > > >
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.Net email is sponsored by xPML, a groundbreaking
> > > scripting language
> > > that extends applications into web and mobile media. Attend
> > > the live webcast
> > > and join the prime developer group breaking into this new
> > > coding territory!
> > > http://sel.as-us.falkag.net/sel?cmd=3Dk&kid=110944&bid$1720&dat=12164=
2
> > > _______________________________________________
> > > Devmon-support mailing list
> > > Dev...@li...
> > > https://lists.sourceforge.net/lists/listinfo/devmon-support
> > >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by xPML, a groundbreaking scripting lang=
uage
> > that extends applications into web and mobile media. Attend the live we=
bcast
> > and join the prime developer group breaking into this new coding territ=
ory!
> > http://sel.as-us.falkag.net/sel?cmdlnk&kid=110944&bid$1720&dat=121642
> > _______________________________________________
> > Devmon-support mailing list
> > Dev...@li...
> > https://lists.sourceforge.net/lists/listinfo/devmon-support
> >
>