[Devmon-devel] Extra note lines in message files causes 3 extra broken graphs

[Jeremy L. <jla...@re...>]

Hi

I just worked out why all of my if_err and if_dsc pages try to show 3
extra graphs with no RRD files.  It's because of the way Xymon counts
lines after the "<!--DEVMON" string appears.  The messages files under
if_dsc and if_err for almost all Cisco devices have an extra 3 lines:

  Note:
  Error rates are per second.
  Load percentages are based on error/bit ratio.

This is not a problem for if_dsc for cisco-857, cisco-871 and
cisco-asa templates because these have the 3 "note" lines above the
TABLE instead of below it.  Indeed Buchan fixed the ASA template with
the comment "Move notes above the table to avoid spurious graph icons"
(see http://devmon.svn.sourceforge.net/viewvc/devmon/trunk/templates/cisco-asa/if_dsc/message?r1=22&r2=64).
 But only the one template was fixed.

I propose that this fix-up be applied to all templates that have extra
"Note" details after the table.

Preferably, Xymon needs to be able to accommodate post-data notes like
this.  As it already recognises the "<!--DEVMON" marker comment, it
makes sense that it count non-blank lines until the closing comment.

But it's easier to change a template than to change code.

Cheers
Jeremy