Re: [Devmon] Errors when applying revision 228

[Contreras, M. <Mar...@ti...>]

Hi Buchan

>Does reverting to the '|x' version in dm_templates.pm make any difference?

Yes, currently the line (547) in dm_templates.pm for math test that is working in my installation is this:

$temp =~ s/\{\s*\S+?\s*\}|\s|\s\.\s|x|\*|\+|\/|-|\^|%|\||&|\d+(\.\d*)?|\(|\)\s*//g;

With no errors when launching devmon with option "readbbhosts"

In dm_tests.pm:

460: # Convert our math symbols to their perl equivalents
461:    $expr =~ s/\sx\s/ \* /g;  # Multiplication
462:    $expr =~ s/\^/**/g; # Exponentiation

Mario Contreras

-----Mensaje original-----
De: Buchan Milne [mailto:bg...@st...] 
Enviado el: lunes, 31 de octubre de 2011 08:15
Para: dev...@li...
CC: Contreras, Mario
Asunto: Re: [Devmon] Errors when applying revision 228

On Wednesday, 19 October 2011 22:30:39 Contreras, Mario wrote:
> Hi
> 
> 
> 
> Last night I apply revision 228 but when running devmon with 
> -readbbhosts option it started to complain about MATH function:
> 
> 
> 
> "MATH transform uses only math/numeric symbols and an optional 
> precision number at 
> /opt/devmon-0.3.1-beta1/templates/cisco-2800/if_dsc/transforms,
> line 6"
> 
> 
> 
> That line is as follows:
> 
> ifOutBps        : MATH          : {ifOutOps} x 8
> 
> 
> 
> (There is a space at both sides of x)
> 
> 


> 
> After checking the issue more in detail the problem seem to appear 
> because two changes in line 547 of dm_templates.pm: deletion of "|\s"  
> and addition of  "|\sx\s"

I think you mean this change:

http://devmon.svn.sourceforge.net/viewvc/devmon/trunk/modules/dm_templates.pm?r1=208&r2=219

and the associated portion in dm_tests.pm:

http://devmon.svn.sourceforge.net/viewvc/devmon/trunk/modules/dm_tests.pm?r1=192&r2=195&view=patch

Which was replacement of '|x' with '|\sx\s'

This change was specifically to fix a bug affecting the use of the letter x in OID names used in MATH operators (where e.g. {index} would not work as the x would be recognised as a mathematical operator).

The next change to that file allowed the use of '*' as a multiplication operator as well.

> I´m running devmon over a sparc solaris 10 box.
> 
> 
> 
> Any ideas why is happening?

I don't see why this should be causing a problem.

I have a few production servers running r214 without problem (which, granted, doesn't have the dm_templates.pm part), and my laptop has a clean checkout of trunk monitoring at least itself with linux-netsnmp template, with working if_load graphs.

I really can't see how this could have broken ...

Does reverting to the '|x' version in dm_templates.pm make any difference?

Regards,
Buchan

Este mensaje (incluyendo cualquier anexo) contiene información confidencial que se encuentra protegida por la ley. La información que contiene sólo puede ser utilizada por la persona o la compañía a la cual está dirigido. Si usted no es un receptor autorizado, o por error recibe el mensaje, omita su contenido y elimínelo inmediatamente. Cualquier retención, difusión, distribución y/o copia así como la ejecución de cualquier acción basado en el contenido del mismo, se encuentra estrictamente prohibido, y esta amparado por la ley.
--------------

This message (including any attachments) contains confidential information intented for a specific individual and purpose, and is protected by law. If you are not the intented recipient, you should delete this message. Any disclosure, copying, or distribution of this message, or the taking of any action based on it, is strictly prohibited.