Re: [Devmon] Undefined subroutine &&dm_templates

[Buchan M. <bg...@st...>]

On Monday, 23 November 2009 12:34:16 Hermann-Josef Beckers wrote:
> Hi,
>
> trying to start devmon under openSUSE 11.1 with xymon 4.3.0beta2:

It looks like you didn't download any templates.

> "./devmon  -f -vv -c ./devmon.cfg --readbbhosts"
>
> gives the following error:
>
> [09-11-23@12:30:46] Option 'bblocation' defaulting to:
> Undefined subroutine &dm_templates::log_fatal called at
> /home/xymon/devmon-0.3.1-beta1/modules/dm_templates.pm line 175.

$ head -n 176 modules/dm_templates.pm|tail -n5

   # Get all dirs in templates subdir
    my $template_dir = $g{'homedir'} . "/templates";
    opendir TEMPLATES, $template_dir or
      log_fatal("Unable to open template directory ($!)",0);

1)dm_config wasn't exporting the log_fatal subroutine, this is fixed in svn (rev 
159 - http://devmon.svn.sourceforge.net/viewvc/devmon?view=rev&revision=159). 
With this fix, the error message becomes:

[09-11-23@14:44:19] Unable to open template directory (No such file or 
directory)

2)I am happy to improve this. The options I can think of are:
-ship an empty templates directory in devmon itself, or maybe a directory 
containing a README file
-improve the error message to be more helpful, something like:

[09-11-23@14:45:53] Unable to open template directory (No such file or 
directory). Did you download the template tarball?

3)I guess the docs/INSTALLATION file should explicitly mention this (or, should 
have, since the time templates were split from "code", which happened before 
my time).

I've adjusted this in the INSTALLATION file: 
http://devmon.svn.sourceforge.net/viewvc/devmon?view=rev&revision=162

Regards,
Buchan