From: Richard F. <gol...@gm...> - 2009-02-12 11:11:41
|
On Thu, Feb 12, 2009 at 1:50 AM, Buchan Milne <bg...@st...> wrote: > On Thursday 12 February 2009 10:55:00 Richard Finegold wrote: >> On Mon, Feb 2, 2009 at 8:39 AM, Buchan Milne <bg...@st...> > wrote: >> > For those who didn't notice, I released 0.3.1-beta1 on 23 Jan. >> > >> > I would appreciate feedback from anyone who has run this. Release notes >> > are available on the links included below. >> >> Could the first line in a table use th instead of td? > I don't see a reason why not. I'll test it here quickly. Thanks. Patch sent. >> Could the TABLE:rrd()'s other options be documented in docs/GRAPHING? > > I'll take a look, but I can't think of much that should be documented ... Only DS: is mentioned in docs/GRAPHING. dm_tests.pm and dm_templates.pm mention: all dir max name:* pri:* >> I'm wondering if there's a way to set the second column as the >> filename (e.g. for the dell-poweredge temperature, so it could use >> "BMC Ambient" instead of "3"). From looking elsewhere in dm_tests.pm >> it seems I might be able to do it with name: or pri: but I'm not sure. > > Unfortunately the code relies on it being the primary repeater. What you could > try is a transform to concatenate the ID and the name, and use that value as > the primary repeater. The problem is, if we just use the name, some devices > (e.g. HP Proliant) will have a number of entries with the same name (e.g. > cpu). For example, I have (for a DL580): > > ID Sensor Location Temp Threshold Condition Threshold Type > 1 cpu 36 80 green OK Caution > 2 cpu 36 80 green OK Caution > 3 cpu 34 80 green OK Caution > 4 cpu 34 80 green OK Caution > 5 ioBoard 32 60 green OK Caution > 6 ambient 21 40 green OK Caution > 7 System 32 60 green OK Caution > > Something like this should be easy, and while not ideal, may be better: > > SensorID Location Temp Threshold Condition Threshold Type > cpu1 cpu 36 80 green OK Caution > cpu2 cpu 36 80 green OK Caution > cpu3 cpu 34 80 green OK Caution > cpu4 cpu 34 80 green OK Caution > ioBoard5 ioBoard 32 60 green OK Caution > ambient6 ambient 21 40 green OK Caution > System7 System 32 60 green OK Caution It'll be a bit odd to change the formatting from ID, but in the pursuit of easy reading, I'll do it. >> Could TABLE:rrd be mentioned in docs/TEMPLATES? Perhaps something like: >> rrd >> See the GRAPHING document in the docs directory >> I ended up doing `grep rrd docs/*` trying to figure it out. >> >> Working well so far! > > I'll try and remember ... but I always check the tracker when trying to > finalise a release. Patch submitted. ;D |