[Devmon] extra-rrd.pl vs devmon RRD support

[Buchan M. <bg...@st...>]

The extra-rrd.pl in svn isn't using the RRD ds definitions that devmon sends 
(based on the template):

<!--DEVMON RRD: if_load 0 0
DS:ds0:COUNTER:600:0:U DS:ds1:COUNTER:600:0:U
[....]
-->

So, according to most of the current templates for if_load, the ds names 
are "ds0" and "ds1", not "in" and "out". Also, the DS definitions are 
hardcoded in the current extra-rrd.pl, and the script needlessly limits 
itself to working on specific tests (while they are already limited by the 
hobbitd_channel command).

I have attached the version I am currently using (which also works with the 
temp tests for compaq-server and dell-poweredge (which have:
TABLE: noalarmsmsg,rrd(DS:ds0:cpqHeTemperatureCelsius:GAUGE; 
DS:ds1:cpqHeTemperatureThreshold:GAUGE)
and
TABLE: noalarmsmsg,rrd(DS:ds0:temperatureProbeReadingCelsius:GAUGE; 
DS:ds1:temperatureProbeLowerCriticalThresholdCelsius:GAUGE).

So, I think it would be best to ship the final 0.3.0 with this being 
consistent (it wouldn't make sense to change it later). So, either we should 
change the templates, or people who have been using the current extra-rrd.pl 
should fix their data after upgrading, with something like:


# for i in `find /var/lib/hobbit/rrd/ -name 'if_load.G*.rrd' `;do mv $i 
$i.old; rrdtool dump $i.old|sed -e 's/ in / ds0 /g;s/ out / ds1 /g;'|rrdtool 
restore - $i;done
# chown -R hobbit:hobbit /var/lib/hobbit/rrd/


I am also looking at the possibility of shipping a patch for hobbit so that 
the extra-script is not necessary, and this would definitely have to use the 
RRD definitions devmon includes.

Regards,
Buchan