Re: [Devil-linux-develop] init.d/network script and dhcpd client

[Heiko Z. <he...@zu...>]

Andrzej,

This has been added to CVS. Thanks for you submission!

Best Regards
  Heiko Zuerker


-----Original Message-----
From: Andrzej Odyniec [mailto:an...@ma...] 
Sent: Monday, November 12, 2012 8:11 AM
To: dev...@li...
Subject: [Devil-linux-develop] init.d/network script and dhcpd client

Dear Heiko,

There are totally not urgent fixes to the script init.d/network, but worth
consideration with the next edition.

Tere are two problems with network starting script, occuring in rare cases.

First. The problem manifests itself when two or more interfaces has set
DHCP=yes (which is quite rare for routers). network script starts dhcpcd
client for each interface separately, but each involves a separate pid file
with name of the device as the name suffix. To specify the name of pid file
killproc function is ready but loadproc is not and therefore loadproc check
the presence of common pid file. Therefore, the second instance of dhcpcd
client does not start.

Fix requires modification of loadproc function (in functions) by adding the
option of the form "-p name.pid" like in killproc and (in network script
itself) callings to startup and stopping of dhcpcd client.

Second. The problem is when closing labeled interfaces, such as eth0:1,
eth0:2 etc -- labeled interfaces are not closing correctly. The interface
definition files in the /etc/sysconfig/nic are elaborated in sequence of
"ls" command. 
Labeled interface files are adding IP address to the main interface when
opening and taken away at closing. When stopping interfaces, reverse list
order is needed for closing labelled interfaces before main and, therefore,
we need use the command "ls -1 -r". This change is needed only in script
network.

Patches are included

Best regards

--
Andrzej Odyniec

<an...@ma...>
Rada Nadzorcza Macrologic SA
ul. Kłopotowskiego 22, 03-717 Warszawa
tel. +48-222566332, kom. +48-601276572
Skype: andrzej.odyniec
Rejestr: Sąd Rejonowy dla m.st. Warszawy,
          XIII Wydział Gospodarczy Krajowego
          Rejestru Sądowego, numer 0000045462 Numer identyfikacji
podatkowej: PL 5220002825 Kapitał zakładowy: 1888719 zł opłacony w całości