Re: [Devil-linux-develop] iptraf and OpenVPN tun interfaces

[Heiko Z. <he...@zu...>]

Quoting Andrzej Odyniec <an...@ma...>:

> Heiko,
>
> I wrote:
>> I will check this problem. Maybe unsorted list of interfaces in  
>> /proc/net/dev is by error, not by design. Or maybe not.
>
> For this I need some days, because many interfaces I have only on  
> one, central router. To test, I need free night. So be patient.

Okay.

>> I will test my patch in both 32-bit and 64-bit compilation,  
>> because, as for now I only tested it on 32-bit compilation on my  
>> router.
>>
>> Iptraf code is old and raw, so there can be surprises with  
>> completly succesfull patching.
>
> So... as for now, I prophesied. Testing my patch (still looks to be  
> a valid) I found bug in iptraf, which manifests itself in the 64-bit  
> compilation. In trimming interface name read from /proc/net/dev is  
> used strcpy in improper manner to overlaping strings. Here is patch  
> correcting this error. This patch is independent from previous  
> patch, sorting interfaces.

Any issues with this patch being present in the 32 bit version?

-- 

Regards
   Heiko Zuerker
   http://www.devil-linux.org