From: Roland P. <pa...@ta...> - 2004-06-26 00:30:31
Attachments:
gpm-makefile.diff
|
Hi, I've done some testing with gpm and it looks like 1.20.1 has two flaws: - it's not parallel build safe, a 'mv' statement is executed twice which can result in a race condition - doc/Makefile.in is broken in case 'makeinfo' is missing, which breaks building of the doc/ subdirectory The patch corrects both (until the author of gpm fixes them) Roland -- ICQ UIN 49339118 Linux Counter #88774 GPG-Key 1024D/59C6AFA6 2003-02-07 Roland Pabel <ro...@pa...> |
From: Heiko Z. <he...@zu...> - 2004-06-26 02:55:18
|
Roland Pabel wrote: > Hi, > I've done some testing with gpm and it looks like 1.20.1 has two flaws: > - it's not parallel build safe, a 'mv' statement is executed twice which can > result in a race condition > - doc/Makefile.in is broken in case 'makeinfo' is missing, which breaks > building of the doc/ subdirectory > The patch corrects both (until the author of gpm fixes them) > Roland > That's what I get: sed: -e expression #1, char 60: Unknown option to `s' It's already checked in to CVS (I know I know, next time I test it before...) Heiko |
From: Roland P. <pa...@ta...> - 2004-06-26 05:53:30
Attachments:
gpm-makefile2.diff
|
On Saturday 26 June 2004 04:51, Heiko Zuerker wrote: > Roland Pabel wrote: > > Hi, > > I've done some testing with gpm and it looks like 1.20.1 has two flaws: > > - it's not parallel build safe, a 'mv' statement is executed twice which > > can result in a race condition > > - doc/Makefile.in is broken in case 'makeinfo' is missing, which breaks > > building of the doc/ subdirectory > > The patch corrects both (until the author of gpm fixes them) > > Roland > > That's what I get: > sed: -e expression #1, char 60: Unknown option to `s' > sorry, somehow a whitespace got lost Roland -- ICQ UIN 49339118 Linux Counter #88774 GPG-Key 1024D/59C6AFA6 2003-02-07 Roland Pabel <ro...@pa...> |
From: Heiko Z. <he...@zu...> - 2004-06-26 13:41:20
|
Roland Pabel wrote: > On Saturday 26 June 2004 04:51, Heiko Zuerker wrote: > >>Roland Pabel wrote: >> >>>Hi, >>>I've done some testing with gpm and it looks like 1.20.1 has two flaws: >>>- it's not parallel build safe, a 'mv' statement is executed twice which >>>can result in a race condition >>>- doc/Makefile.in is broken in case 'makeinfo' is missing, which breaks >>>building of the doc/ subdirectory >>>The patch corrects both (until the author of gpm fixes them) >>>Roland >> >>That's what I get: >>sed: -e expression #1, char 60: Unknown option to `s' >> > > sorry, somehow a whitespace got lost No Problem. It's in CVS now. Heiko |