devil-linux-develop

[Devil-linux-develop] [Patch] network script

[Thomas E. <tho...@bu...>]

the /etc/sysconfig/nic/ifcfg-vlanXXX doesn't work without this patch:

--- config/etc/init.d/network.old       2004-02-11 00:09:57.000000000 +0100
+++ config/etc/init.d/network   2004-02-11 00:10:25.000000000 +0100
@@ -275,9 +275,9 @@
         start)

                 #
-               # if vlan tools are installed set vlan naming shema
+               # set vlan naming shema
                 #
-               test -x $VLAN && $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
+               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null

                 #
                 # physical interfaces are brought up first


-- 
thomas

Re: [Devil-linux-develop] [Patch] network script

[Friedrich L. <fl...@fl...>]

Thomas Eder wrote on 11.02.2004 00:30 MET:
> the /etc/sysconfig/nic/ifcfg-vlanXXX doesn't work without this patch:
> 
> --- config/etc/init.d/network.old       2004-02-11 00:09:57.000000000 +0100
> +++ config/etc/init.d/network   2004-02-11 00:10:25.000000000 +0100
> @@ -275,9 +275,9 @@
>         start)
> 
>                 #
> -               # if vlan tools are installed set vlan naming shema
> +               # set vlan naming shema
>                 #
> -               test -x $VLAN && $VLAN set_name_type 
> VLAN_PLUS_VID_NO_PAD &> /dev/null
> +               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null


OK, I think after taking a closer look at the network script I know what 
the real problem is.

Please change the VLAN varibale (around line 42) to reflect the full patch 
of the vconfig utility. Run "which vconfig" to find out.


-- 
MfG / Regards
Friedrich Lobenstock
____________________________________________________________________
Friedrich Lobenstock                       Linux Services Lobenstock
URL: http://www.lsl.at/                         Email: fl...@fl...
____________________________________________________________________

Re: [Devil-linux-develop] [Patch] network script

[Friedrich L. <fl...@fl...>]

Friedrich Lobenstock wrote on 11.02.2004 00:37 MET:
> 
> OK, I think after taking a closer look at the network script I know what 
> the real problem is.
> 
> Please change the VLAN varibale (around line 42) to reflect the full 
> patch of the vconfig utility. Run "which vconfig" to find out.

It's too late in the night - or early in the morning.

Of course I meant "path" _not_ "patch".


-- 
MfG / Regards
Friedrich Lobenstock
____________________________________________________________________
Friedrich Lobenstock                       Linux Services Lobenstock
URL: http://www.lsl.at/                         Email: fl...@fl...
____________________________________________________________________

Re: [Devil-linux-develop] [Patch] network script

[Thomas E. <tho...@bu...>]

Friedrich Lobenstock wrote:
> Thomas Eder wrote on 11.02.2004 00:30 MET:
> 
>> the /etc/sysconfig/nic/ifcfg-vlanXXX doesn't work without this patch:
>>
>> --- config/etc/init.d/network.old       2004-02-11 00:09:57.000000000 
>> +0100
>> +++ config/etc/init.d/network   2004-02-11 00:10:25.000000000 +0100
>> @@ -275,9 +275,9 @@
>>         start)
>>
>>                 #
>> -               # if vlan tools are installed set vlan naming shema
>> +               # set vlan naming shema
>>                 #
>> -               test -x $VLAN && $VLAN set_name_type 
>> VLAN_PLUS_VID_NO_PAD &> /dev/null
>> +               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
> 
> 
> 
> OK, I think after taking a closer look at the network script I know what 
> the real problem is.
> 
> Please change the VLAN varibale (around line 42) to reflect the full 
> patch of the vconfig utility. Run "which vconfig" to find out.
> 
> 

--- config/etc/init.d/network.old       2004-02-11 00:09:57.000000000 +0100
+++ config/etc/init.d/network   2004-02-11 00:44:19.000000000 +0100
@@ -39,7 +39,7 @@
  [ -s /etc/sysconfig/network/config ] && . /etc/sysconfig/network/config
  [ -s /etc/sysconfig/network/dhcp ] && . /etc/sysconfig/network/dhcp

-VLAN=vconfig
+VLAN=/bin/vconfig

  CONFIG_DIR=/etc/sysconfig/nic
  CONFIG_FILE=ifcfg-
@@ -275,9 +275,9 @@
         start)

                 #
-               # if vlan tools are installed set vlan naming shema
+               # set vlan naming shema
                 #
-               test -x $VLAN && $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
+               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null

                 #
                 # physical interfaces are brought up first


-- 
thomas

Re: [Devil-linux-develop] [Patch] network script

[Friedrich L. <fl...@fl...>]

Thomas Eder wrote on 11.02.2004 00:49 MET:
> Friedrich Lobenstock wrote:
> 
>> Thomas Eder wrote on 11.02.2004 00:30 MET:
>>
>>> the /etc/sysconfig/nic/ifcfg-vlanXXX doesn't work without this patch:
>>>
>>> --- config/etc/init.d/network.old       2004-02-11 00:09:57.000000000 
>>> +0100
>>> +++ config/etc/init.d/network   2004-02-11 00:10:25.000000000 +0100
>>> @@ -275,9 +275,9 @@
>>>         start)
>>>
>>>                 #
>>> -               # if vlan tools are installed set vlan naming shema
>>> +               # set vlan naming shema
>>>                 #
>>> -               test -x $VLAN && $VLAN set_name_type 
>>> VLAN_PLUS_VID_NO_PAD &> /dev/null
>>> +               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
>>
>>
>>
>>
>> OK, I think after taking a closer look at the network script I know 
>> what the real problem is.
>>
>> Please change the VLAN varibale (around line 42) to reflect the full 
>> patch of the vconfig utility. Run "which vconfig" to find out.
> 
>  
> -VLAN=vconfig
> +VLAN=/bin/vconfig
>   
> ..[..cut..]..
> -		# if vlan tools are installed set vlan naming shema
> +		# set vlan naming shema
>  		#
> -		test -x $VLAN && $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
> +		$VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null

If you change the above then the "test -x" should successfully run the vlan 
utility. Please test with only changing the VLAN variable. THX.

-- 
MfG / Regards
Friedrich Lobenstock
____________________________________________________________________
Friedrich Lobenstock                       Linux Services Lobenstock
URL: http://www.lsl.at/                         Email: fl...@fl...
____________________________________________________________________

Re: [Devil-linux-develop] [Patch] network script

[Thomas E. <tho...@bu...>]

Friedrich Lobenstock wrote:
> Thomas Eder wrote on 11.02.2004 00:49 MET:
> 
>> Friedrich Lobenstock wrote:
>>
>>> Thomas Eder wrote on 11.02.2004 00:30 MET:
>>>
>>>> the /etc/sysconfig/nic/ifcfg-vlanXXX doesn't work without this patch:
>>>>
>>>> --- config/etc/init.d/network.old       2004-02-11 
>>>> 00:09:57.000000000 +0100
>>>> +++ config/etc/init.d/network   2004-02-11 00:10:25.000000000 +0100
>>>> @@ -275,9 +275,9 @@
>>>>         start)
>>>>
>>>>                 #
>>>> -               # if vlan tools are installed set vlan naming shema
>>>> +               # set vlan naming shema
>>>>                 #
>>>> -               test -x $VLAN && $VLAN set_name_type 
>>>> VLAN_PLUS_VID_NO_PAD &> /dev/null
>>>> +               $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
>>>
>>>
>>>
>>>
>>>
>>> OK, I think after taking a closer look at the network script I know 
>>> what the real problem is.
>>>
>>> Please change the VLAN varibale (around line 42) to reflect the full 
>>> patch of the vconfig utility. Run "which vconfig" to find out.
>>
>>
>>  
>> -VLAN=vconfig
>> +VLAN=/bin/vconfig
>>   ..[..cut..]..
>> -        # if vlan tools are installed set vlan naming shema
>> +        # set vlan naming shema
>>          #
>> -        test -x $VLAN && $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> 
>> /dev/null
>> +        $VLAN set_name_type VLAN_PLUS_VID_NO_PAD &> /dev/null
> 
> 
> If you change the above then the "test -x" should successfully run the 
> vlan utility. Please test with only changing the VLAN variable. THX.
> 

Klaer mich bitte auf, aber:

ich glaube /bin /usr/bin /sbin /usr/sbin sind bei den meisten linux/unix in $PATH enthalten, daraus 
folgt fuer mich, dass VLAN=vconfig "fast immer" stimmt. Wenn /bin/vconfig auf zb. /sbin/vconfig 
geaendert wird, hast du mit unserem script ein _Problem_.
Das "test -x $VLAN" ist, seit DL auf _CD_ ist eigentlich absurd, oder kennst du einen Weg um Dateien 
von der RO CD zu "deaktivieren".
Wenn du sagen wuerdest wir testen ob es vlan ueberhaupt verwendet wird, ok aber so tauschen wir 
einen "Fehler" durch einen anderen :-(

-- 
thomas

Re: [Devil-linux-develop] [Patch] network script

[Friedrich L. <fl...@fl...>]

Ok I've checked-in the following changes to the network script (both for 
1.0.x and 1.1.x).

--- network	31 Dec 2003 21:26:53 -0000	1.27
+++ network	11 Feb 2004 16:57:08 -0000	1.28
@@ -41,3 +41,3 @@

-VLAN=vconfig
+VLAN=/bin/vconfig


-- 
MfG / Regards
Friedrich Lobenstock
____________________________________________________________________
Friedrich Lobenstock                       Linux Services Lobenstock
URL: http://www.lsl.at/                         Email: fl...@fl...
____________________________________________________________________