dev-cpp-users

[Dev-C++] Optimizing using the STL

[David M. <ci...@ya...>]

Any suggestions on how I can optimized the following
function?

void pc_char::write_to_all_pc(string to_send, bool
add_eoln)
{
  map<string, pc_char *>::iterator i =
current_players.begin();

  while (i != current_players.end()) {
    (*i).second->write_to_player(to_send, add_eoln);
  }           
}

I was hoping to use for_each but kept coming across the
problem of "How the hell am I going to pass the arguments
to write_to_player?"

Thanks in Advance

=====
Signed 
David Mcken

Life Sucks
Live with it

__________________________________
Do you Yahoo!?
Yahoo! SiteBuilder - Free, easy-to-use web site design software
http://sitebuilder.yahoo.com

RE: [Dev-C++] Optimizing using the STL

[Abhijit S. <mu...@gm...>]

Hello, David.

> Any suggestions on how I can optimized the following
> function?
>
> void pc_char::write_to_all_pc(string to_send, bool
> add_eoln)
> {
>   map<string, pc_char *>::iterator i =
> current_players.begin();
>
>   while (i != current_players.end()) {
>     (*i).second->write_to_player(to_send, add_eoln);
>   }
> }
>
> I was hoping to use for_each but kept coming across the
> problem of "How the hell am I going to pass the arguments
> to write_to_player?"

I'm not exactly an STL hacker, so I wouldn't know if there's a more elegant
solution, but here's my idea:

You can maintain a namespace with pointers to arguments for
write_to_player() and empty-out the arg-list of write_to_player() (and
probably write an inline wrapper to map from arg-list to this namespace for
normal calls). Then intially set up to_send and add_eoln in that namespace
and call for_each() with begin and end. This will work here because the
arguments are common.

--
Abhijit Shylanath
Homepage: http://mudeth.tripod.com/

RE: [Dev-C++] Optimizing using the STL

[Abhijit S. <mu...@gm...>]

Addendum:

> > void pc_char::write_to_all_pc(string to_send, bool

And another thing; wherever possible, pass by reference rather than by
value. It's much more efficient for classes. For example, make
write_to_all_pc:

	void pc_char::write_to_all_pc(const string &to_send, bool whatever)

Note that the `const' also helps in optimization; gcc will know that the
parameter is not modified, and make optimization arrangements based on this.
This should actually give you more of a speed-boost than the previous thing
I suggested.

PS: As I mentioned, I am not an STL-wise person, so if the above
optimization is insignificant because of the way the string class works,
sorry.

--
Abhijit Shylanath
Homepage: http://mudeth.tripod.com/