#59 please don't list local addresses or ips

[Karl Goetz]

Hi,
I'm running git head, and I hae the following list:

To access this scoreboard from other computers on this network, try one of these URLs:

http://172.17.43.10:8000/
http://localhost:8000/
http://127.0.0.1:8000/

the bottom two will never work, so it would be great if the scoreboard would avoid suggesting them. I'd suggest ignoring anything that resolves to 127/8, as they won't be reachable from the network.

[Andrew]

I wouldn't jump to say never, as it will work on the server. How about leaving those two off, unless no other address is found (ie: in a single machine setup) and state that the machine is offline and will only work locally?

[Karl Goetz]

Good point about 'single system' setups.

Even if there is only loopback addresses available, I still feel only one of them needs to be displayed in that case though, since they resolve to the same place.
if someone has specifically configured it to listen somewhere other then default, the scoreboard should start there and base its links around that setup.

[Dan Streetman]

I updated the main UrlsServlet class to ignore any loopback address.

There are only 2 places (currently) that the addresses are shown, in the status messages during startup, and on the index.html page.

The status messages are hardcoded to always show http://localhost:<port>. If the scoreboard isn't listening to any other interfaces, then that's the only one shown in the startup messages (otherwise, the other urls are shown).</port>

On the index.html page, http://localhost:<port> isn't shown because the user has to already be viewing that URL or one of the other networked URLs, so if the scoreboard is set up only to listen to the loopback address, the user must already be viewing the localhost URL.</port>

Open this bug back up if you think it should be adjusted.