[Decker-jdecker] Some aspects of required code refactoring for JDecker
Brought to you by:
fsovercash,
zyphrus
|
From: Vasilij S. <vas...@gm...> - 2008-01-24 21:23:54
|
Greetings, Decker list for historical purposes. I was going through code just before going to bed and found some fairly fascinating things. Are there any particular reason you are re-implementing basic Java stuff? Because both Queue and StringTreeMap seem to be rather redundant. Queue has implementation in Java. Here is the Javadoc for it: http://java.sun.com/j2se/1.5.0/docs/api/java/util/AbstractQueue.html If I understood StringTreeMap properly you have implemented Map functionality with Tree structure. Though motivation is not clear for me. I would go with Map(http://java.sun.com/j2se/1.5.0/docs/api/java/util/Map.html) as generic data structure and HashMap ( http://java.sun.com/j2se/1.5.0/docs/api/java/util/HashMap.html) as implementation. I do believe Java engineers did a decent job implementing this basic stuff properly. I also do not understand what is ArrayModifier class for? Is it dynamic array implementation? If so, there is better way to do it. Also, what is motivation for extending StringPrintStream? Regards, Vasilij Savin |