From: Christian S. <csc...@gm...> - 2005-09-21 17:08:54
|
hi nicolas, Am Mittwoch, den 21.09.2005, 01:45 +0200 schrieb Nicolas Boichat: > Hi Christian, > > On Wed, 2005-09-21 at 00:34 +0200, Christian Schilling wrote: > > hi nicolas, > > > > i think we can use this icon for now. as it is a part of gnome there is > > no need for copying it. it can just be accessed via it's iconname: > > "display-capplet". > > i have already made the changes to the applet. and will now create > > the .desktop file for gddcontrol's menu entry with this icon. > > Ok. Please also test what happens if the icon is not installed on the > system, it should not display a message box or something like that. i think most user will have it, as it is part of gnome. but in case it's not on the system there is no error message, but an other icon is shown instead (red cross on "paper") > > the integration of intltool also changes the way POTFILES.in is > > maintained. the "intltool-update -m" command scans the sources and > > creates a "missing" file containing all sources not mentioned in > > POTFILES.in > > Great! .-) I thought that my small trick was not the correct way of > doing this .-) Thanks! intltool can also handle updating of the .po files themselves: intltool-update fr will get all marked strings and automaticly merge with existing french translations :-) > > > while making this changes i noticed there are many autogenerated files > > in the CVS witch in my opinion should not be there. i'll leave this > > as-is but i'd like to know what you think about removing them. > > I think things like configure, aclocal.m4 and Makefile.in could be > removed safely... > When I was the only one to develop, it was not a problem to have these > files, but now, they get regenerated each time you do a commit because > we don't have the same version of automake (1.9.6 for you and 1.9.7 for > me). > So just go on, delete the files you think should not be there (please > also update the .cvsignore files), and if there is a problem we can > always add some of them back later. i removed a lot of files (and added them to .cvsignore) but all of them are generated during ./autogen.sh or a later script. you'll see the dir gets quite tidy when doing rm $(cat .cvsignore) while working on intltool interation i noticed you use the N_() macro quite extensivly to do nothing, is there any special reason for this? i ask because usually N_() is used for a different purpose: to mark static strings with cannot directly translated by a function all, but are later translated in place: const char* foo = N_("whatever"); ..... printf(gettext(foo)); i added N_ to xgettext keywords (because intltool needs that), and know a lot of strings witch don't need translation are pulled into the .po files best regards christian ps.: do you have some kind of instant messaging? maybe this would be handy for minor questions/discussions ;-) |