#123 arabic.sql and libarabic.dll don't match

closed
None
5
2007-06-20
2007-06-19
No

When using

./configure
make

libarabic.dll or libarabic.so will be created while
the generated arabic.sql refers to $libdir/arabic.

The makefile should either rename the DLL or
adjust arabic.sql.

The solution for this problem should also take the upgrading process for existing installations into consideration.

Discussion

  • Steffen Macke

    Steffen Macke - 2007-06-20

    Logged In: YES
    user_id=30248
    Originator: YES

    Corrected summary.

     
  • Steffen Macke

    Steffen Macke - 2007-06-20
    • summary: arabic.sql and libarabic.sql don't match --> arabic.sql and libarabic.dll don't match
     
  • Maher Abdel Karim

    Logged In: YES
    user_id=695149
    Originator: NO

    libarabic.dll was already implemented before.
    the code which creates the sql file should use libarabic.dll instead of arabic
    This was already implemented by Steffen in
    2004-08-14 Steffen Macke <Steffen_Macke@dorsch.com.jo>

    Some how this was changed and not documented.
    The bug is fixed.

     
  • Maher Abdel Karim

    • status: open --> closed
     
  • Maher Abdel Karim

    Logged In: YES
    user_id=695149
    Originator: NO

    adjusting the installer to rename the libarabic.dll to arabic.dll.

     
  • Steffen Macke

    Steffen Macke - 2007-06-20
    • assigned_to: nobody --> sdteffen
     
  • Steffen Macke

    Steffen Macke - 2007-06-20

    Logged In: YES
    user_id=30248
    Originator: YES

    libarabic.dll was used by the previous releases and I think you should stick to it.
    Imagine the following scenario:

    * Existing 8.1 database, referencing $libdir/libarabic.dll is dumped
    * PostgreSQL 8.2 is installed along with PostArabic 1.0.4
    * When restoring the database, $libdir/libarabic.dll is missing

    I also don't like keeping two DLLS with the same content (arabic.sql and libarabic.sql).
    I've therefore removed the *.nsi hotfix. Also keep in mind that this hotfix does not
    work for non-Windows platforms.

    Convincing PGXS to use libarabic.dll in the SQL definition script is as easy as renaming
    arabic.sql to libarabic.sql. I've done this in SVN head. I hope that you agree to this approach.

     
  • Maher Abdel Karim

    Logged In: YES
    user_id=695149
    Originator: NO

    I agree to keep the use of libarabic.dll and not go to arabic.dll

    The arabic.sql should contains the reference to libarabic.dll instead of arabic.dll the sql creation template should be adjusted to create this.
    The file which used to specify the output referenced dll in the arabic.sql is not clear.