| and || mixup ?
Brought to you by:
josephlininger,
mlevendo
modechange.c:347]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.
Source code is
/* Affect the execute bits if execute bits are already set
or if the file is a directory. */
if ((newmode & (S_IXUSR | S_IXGRP | S_IXOTH)) | dir)
value |= S_IXUSR | S_IXGRP | S_IXOTH;
Maybe better code
/* Affect the execute bits if execute bits are already set
or if the file is a directory. */
if ((newmode & (S_IXUSR | S_IXGRP | S_IXOTH)) || dir)
value |= S_IXUSR | S_IXGRP | S_IXOTH;