Re: [dbus-cplusplus-devel] Bug. xml2cpp structure including several simple array.

[Andreas V. <li...@br...>]

Am Wed, 21 Jan 2009 17:41:50 +0100 schrieb Redouane SOUM:

Hello Redouane,

sorry for not answering your mail. I'll try it in the next days. The
problem is that in I work mainly on base of the gitorious branch. The
generator there differs much from the fdo one. So I think it doesn't
apply on my modified generator. But I think it has this bug also.

I search for a way to combine the source of both so that I only have to
work on one source.

I've not yet tried your patch, but will do in the next days.

A good idea for the future would be a set of generator unit tests. Then
one could apply patches and after passing all unit test it could be
applied. Currently I've to test or review that patch. Because if I
apply it with my account I've to "guarantee" for it's correctness.

regards
Andreas

> If we use complex structure that include simple array, the type isn't
> generated properly.
> Exemple : (iiiua(ayayayiiiii))
>  
> Generated type (with current version of xml2cpp):
>  
> ::DBus::Struct< int32_t, int32_t, int32_t, uint32_t,
> std::vector< ::DBus::Struct< std::vector< uint8_t, std::vector<
> uint8_t, std::vector< uint8_t, int32_t, int32_t, int32_t, int32_t,
> int32_t > > > >,
> >
> >, & evt
>  
>  
> Type expected:
>  
>  ::DBus::Struct< int32_t, int32_t, int32_t, uint32_t,
> std::vector< ::DBus::Struct< std::vector< uint8_t >, std::vector<
> uint8_t >, std::vector< uint8_t >, int32_t, int32_t, int32_t,
> int32_t, int32_t > > > evt;
>  
>  
>  
> I would like to submit a patch fixing this problem and adding some
> features:
> 
>  
>  
> Xml2cpp
>         Bug fix:
>              Problem in type generation with complex array
>  
>         Feature:
>             Add nonblock function for each method in the proxy
> generation 
> Dispatcher/connection
>  
>         Feature:
>             Add constructor to create a connection passing a
> dispatcher (instead of creating a connection with default dispatcher
> and use setup after)
>             Add fd to allow dispatcher to leave directly when leave
> method is called (instead of waiting for the timeout on the select)
>  
> Red1
> 
>  
> 
>  
> 
> Ps : see bug https://bugs.freedesktop.org/show_bug.cgi?id=19518
> 
>  
>