Re: [dbus-cplusplus-devel] Question about patches / Question about DBus C header inclusion policies

[P. D. <sh...@gm...>]

On Sat, Jan 17, 2009 at 3:03 AM, Milosz Derezynski
<int...@gm...> wrote:
> I just realized that DBus::Message::get_type() also returns just an int. For
> this to make any sense, that is,
> so API consumers can compare this to the known message types, they have to
> include the dbus-protocol.h
> anyway, or they (bad!) just hardcode the numbers.
>
> So either way it seems that header is needed. But aside from that, the
> question about whether C headers
> can generally be included or not still stands :)
>

What I'm wondering is where you're getting these messages from and why
you have to manually cast them to the appropriate message type.
The way I see it Message::type() (there's no such thing as get_type())
shouldn't be in the public API at all since the returned value is only
used internally to route the message appropriately.

Paolo

> Thanks
> Milosz
>
> On Sat, Jan 17, 2009 at 3:02 AM, Milosz Derezynski <int...@gm...>
> wrote:
>>
>> Hello,
>>
>> I've got 2 questions and one announcement.
>>
>> First the announcement: I've finally started writing the libhalmm rewrite,
>> as a reimplementation of libhal,
>> instead of being a wrapper around the C libhal and libhal-storage.
>>
>> Since the basic work is straightforward I expect that I can make an
>> announcement of the source code
>> within 1-2 weeks; I'll post again then with the checkout URL, etc.
>>
>> Two questions:
>>
>> 1.) Is it OK to post git diffs for dbus-c++ here? (I assume yes, but just
>> wanted to ask)
>>
>> 2.) Is the policy for inclusion of DBus C headers still "No DBus C headers
>> in the public dbus-c++ headers"?
>> I thought we could get rid of some (IMO) stupid things in the DBus C API,
>> e.g. introduce an enum for the
>> message type. However, to take the values from the C API, the C header
>> dbus-protocol.h would need to
>> be included? How is the stance on this policy by now?
>>
>>
>> Cheers
>> Milosz
>>
>> --
>> Please note that according to the German law on data retention,
>> information on every electronic information exchange with me is
>> retained for a period of six months.
>> [Bitte beachten Sie, dass dem Gesetz zur Vorratsdatenspeicherung zufolge
>> jeder elektronische Kontakt mit mir sechs Monate lang gespeichert wird.]
>
>
>
> --
> Please note that according to the German law on data retention,
> information on every electronic information exchange with me is
> retained for a period of six months.
> [Bitte beachten Sie, dass dem Gesetz zur Vorratsdatenspeicherung zufolge
> jeder elektronische Kontakt mit mir sechs Monate lang gespeichert wird.]
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> SourcForge Community
> SourceForge wants to tell your story.
> http://p.sf.net/sfu/sf-spreadtheword
> _______________________________________________
> dbus-cplusplus-devel mailing list
> dbu...@li...
> https://lists.sourceforge.net/lists/listinfo/dbus-cplusplus-devel
>
>