Menu
▾
▴
dbus-cplusplus-devel
|
From: Andreas V. <li...@br...> - 2011-11-26 21:20:12
|
Am Wed, 28 Sep 2011 20:50:06 +0000 schrieb
dbu...@li...:
Decision: Rejected
functional test "Test1" failing:
> ./TestApp
initialize DBus...
Start server...
Start client thread...
write to pipe
lt-TestApp: ../include/dbus-c++/util.h:237: R DBus::Slot<R,
P>::operator()(P) const [with R = void, P = DBus::DefaultTimeout&]:
P>Assertion `not empty()' failed.
gdb:
#0 0x00dcb422 in __kernel_vsyscall ()
#1 0x00419651 in *__GI_raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2 0x0041ca82 in *__GI_abort () at abort.c:92
#3 0x00412718 in *__GI___assert_fail (assertion=0x1ba4bc "not empty()",
file=0x1ba4a1 "../include/dbus-c++/util.h", line=237,
function=0x1ba4e0 "R DBus::Slot<R, P>::operator()(P) const [with R = void, P = DBus::DefaultTimeout&]") at assert.c:81
#4 0x001b3dbd in DBus::Slot<void, DBus::DefaultTimeout&>::operator() (this=0xa05c31c,
param=...) at ../include/dbus-c++/util.h:237
#5 0x001b33a3 in DBus::DefaultMainLoop::dispatch (this=0x805f4e4) at eventloop.cpp:220
#6 0x001b56b9 in DBus::BusDispatcher::do_iteration (this=0x805f4c0)
at eventloop-integration.cpp:148
#7 0x001b5355 in DBus::BusDispatcher::enter (this=0x805f4c0) at eventloop-integration.cpp:99
#8 0x08052cb0 in TestApp::initDBus (this=0xbfaea08c) at TestApp.cpp:54
#9 0x08052b1a in TestApp (this=0xbfaea08c) at TestApp.cpp:29
#10 0x08052859 in main (argc=1, argv=0xbfaea144) at TestAppMain.cpp:11
Please ensure your patch is running at least this basic test. Please provide patches by gitorious or sf.net next time.
regards
Andreas
> As list administrator, your authorization is requested for the
> following mailing list posting:
>
> List: dbu...@li...
> From: qol...@gr...
> Subject: [PATCH 14/15] Replace conditions with asserts where
> return required. Reason: Post by non-member to a members-only list
>
> At your convenience, visit:
>
> https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel
>
> to approve or deny the request.
--
Technical Blog <http://andreasvolz.wordpress.com/>
|
|
From: Andreas V. <li...@br...> - 2011-11-26 21:25:11
|
Am Wed, 28 Sep 2011 20:50:06 +0000 schrieb dbu...@li...: Decision: Rejected > Fix warnings of GCC 4.4.3 with -W -Wall Please point out which changes exactly are problematic for GCC 4.4.3 Changes like this doesn't improve the code: -void ObjectAdaptor::Private::unregister_function_stub(DBusConnection *conn, void *data) +void ObjectAdaptor::Private::unregister_function_stub(DBusConnection *, void *) regards Andreas > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 04/15] Fix warnings of GCC 4.4.3 with -W -Wall. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 21:50:15
|
Am Wed, 28 Sep 2011 20:54:22 +0000 schrieb dbu...@li...: Decision: Rejected Reason: My main application doesn't longer receive signals from the sender. From my understanding signals have no specific destination and so sender filter isn't useful. Use methods for this reason or please explain this pointing on DBus standard. regards Andreas > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 06/15] Filter signals according to their senders. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:15:11
|
Am Wed, 28 Sep 2011 20:54:23 +0000 schrieb dbu...@li...: Decision: Applied To gi...@gi...:dbus-cplusplus/mainline.git 59fc6e9..fcae4df master -> master > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 02/15] Remove useless const qualifiers on return > types. Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:40:13
|
Am Wed, 28 Sep 2011 20:54:23 +0000 schrieb dbu...@li...: Decision: Applied Reason: I personaly don't need it, but as it doesn't hurt anyone. I don't assume relevant increase of memory usage. > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 07/15] Double the number of Struct members. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:50:13
|
Am Sat, 26 Nov 2011 23:37:46 +0100 schrieb Andreas Volz: To gi...@gi...:dbus-cplusplus/mainline.git fcae4df..e8262c2 master -> master > Am Wed, 28 Sep 2011 20:54:23 +0000 schrieb > dbu...@li...: > > Decision: Applied > > Reason: > I personaly don't need it, but as it doesn't hurt anyone. I don't > assume relevant increase of memory usage. > > > As list administrator, your authorization is requested for the > > following mailing list posting: > > > > List: dbu...@li... > > From: qol...@gr... > > Subject: [PATCH 07/15] Double the number of Struct members. > > Reason: Post by non-member to a members-only list > > > > At your convenience, visit: > > > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > > > to approve or deny the request. > > > -- > Technical Blog <http://andreasvolz.wordpress.com/> > > ------------------------------------------------------------------------------ > All the data continuously generated in your IT infrastructure > contains a definitive record of customers, application performance, > security threats, fraudulent activity, and more. Splunk takes this > data and makes sense of it. IT sense. And common sense. > http://p.sf.net/sfu/splunk-novd2d > _______________________________________________ > dbus-cplusplus-devel mailing list > dbu...@li... > https://lists.sourceforge.net/lists/listinfo/dbus-cplusplus-devel > -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:45:11
|
Am Wed, 28 Sep 2011 20:54:24 +0000 schrieb dbu...@li...: Decision: Applied To gi...@gi...:dbus-cplusplus/mainline.git e8262c2..eaeeea6 master -> master > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 01/15] Explicit Connection::Private's attributes > initialization. Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:50:12
|
Am Wed, 28 Sep 2011 20:54:24 +0000 schrieb dbu...@li...: Decision: Rejected Reason: + // FIXME: In case of a null interface, aren't + // FIXME: we supposed to look for a compatible + // FIXME: one, in case there is no ambiguity? + if (not member or not interface) ... + // FIXME: In case of a null interface, aren't + // FIXME: we supposed to look for a compatible + // FIXME: one, in case there is no ambiguity? + if (not interface or not member or not objpath) > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 08/15] Don't try to build std::string objects on > null pointers. Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:50:11
|
Am Wed, 28 Sep 2011 20:54:30 +0000 schrieb dbu...@li...: Decision: Rejected Reason: Violates common (at least my personal) programming rules - Server(const Server &s) + Server(const Server &) > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 13/15] Remove unused argument in Server's > constructor. Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:55:11
|
Am Wed, 28 Sep 2011 20:54:30 +0000 schrieb dbu...@li...: Decision: Applied (slightly modified) To gi...@gi...:dbus-cplusplus/mainline.git eaeeea6..d14c152 master -> master > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 12/15] Fix leftover outputs. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 22:55:12
|
Am Wed, 28 Sep 2011 20:54:31 +0000 schrieb dbu...@li...: Decision: Rejected Reason: Please provide better specific INSTALL if available > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 15/15] Remove generic INSTALL. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-26 23:00:12
|
Am Wed, 28 Sep 2011 21:00:05 +0000 schrieb
dbu...@li...:
Decision: Rejected
Reason: I don't see what the below patch fixes.
diff --git a/src/dispatcher.cpp b/src/dispatcher.cpp
index 2da4e86..aef1437 100644
--- a/src/dispatcher.cpp
+++ b/src/dispatcher.cpp
@@ -181,13 +181,13 @@ void Dispatcher::dispatch_pending()
while (_pending_queue.size() > 0)
{
Connection::PrivatePList::iterator i, j;
-
+
i = _pending_queue.begin();
while (i != _pending_queue.end())
{
- j = i;
-
+ j = i;
+
++j;
if ((*i)->do_dispatch())
> As list administrator, your authorization is requested for the
> following mailing list posting:
>
> List: dbu...@li...
> From: qol...@gr...
> Subject: [PATCH 03/15] Fix a deprecation warning in
> src/dispatcher.cpp. Reason: Post by non-member to a members-only list
>
> At your convenience, visit:
>
> https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel
>
> to approve or deny the request.
--
Technical Blog <http://andreasvolz.wordpress.com/>
|
|
From: Andreas V. <li...@br...> - 2011-11-26 23:05:13
|
Am Wed, 28 Sep 2011 21:00:06 +0000 schrieb
dbu...@li...:
Decision: Rejected
Reason:
diff --git a/src/debug.cpp b/src/debug.cpp
index afc6d3e..8dbba36 100644
--- a/src/debug.cpp
+++ b/src/debug.cpp
@@ -31,9 +31,10 @@
#include <cstdio>
#include <stdlib.h>
-static void _debug_log_default(const char *, ...)
+static void _debug_log_default(const char *format, ...)
--> This one is yet in current source
{
//#ifdef DEBUG
+ // (void) format; // Avoid an unused argument warning when !defined(DEBUG).
--> adding a commented out line doesn't change anything
static int debug_env = getenv("DBUSXX_VERBOSE") ? 1 : 0;
> As list administrator, your authorization is requested for the
> following mailing list posting:
>
> List: dbu...@li...
> From: qol...@gr...
> Subject: [PATCH 05/15] Fix missing argument name.
> Reason: Post by non-member to a members-only list
>
> At your convenience, visit:
>
> https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel
>
> to approve or deny the request.
--
Technical Blog <http://andreasvolz.wordpress.com/>
|
|
From: Andreas V. <li...@br...> - 2011-11-27 22:45:11
|
Am Wed, 28 Sep 2011 20:54:32 +0000 schrieb dbu...@li...: Decision: applied => Syncing Gitorious... [OK] To gi...@gi...:dbus-cplusplus/mainline.git d14c152..2a1e2db master -> master > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 11/15] Have Object subclasses NOT throw > exceptions in destructors. Reason: Post by non-member to a > members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
|
From: Andreas V. <li...@br...> - 2011-11-28 11:00:14
|
Am Wed, 28 Sep 2011 21:00:03 +0000 schrieb dbu...@li...: Decision: Rejected Reason: Possible bad side effect on "org.freedesktop.DBus.Object" feature expected. Please show generated code as example where ri is declarated useless. Please provide XML code that generates problem. Hint: applied included improvement for func.size() > 0 now check with !empty() in complete generator => Syncing Gitorious... [OK] To gi...@gi...:dbus-cplusplus/mainline.git 74c1ee3..b100e9d master -> master > As list administrator, your authorization is requested for the > following mailing list posting: > > List: dbu...@li... > From: qol...@gr... > Subject: [PATCH 10/15] Don't add useless declaration of ri. > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > https://lists.sourceforge.net/lists/admindb/dbus-cplusplus-devel > > to approve or deny the request. -- Technical Blog <http://andreasvolz.wordpress.com/> |
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X